Skip to content

Commit

Permalink
upgrade kafka-clients library to 2.3.0 because of CVE-2018-17196, upg…
Browse files Browse the repository at this point in the history
…rade docker images in example, added OWASP dependency check
  • Loading branch information
Antonin Stoklasek committed Aug 4, 2019
1 parent f793301 commit 6a67397
Show file tree
Hide file tree
Showing 7 changed files with 32 additions and 14 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ How to quickly start using the Event Store Kafka with your Java EE 8 project.
<dependency>
<groupId>net.osomahe</groupId>
<artifactId>eventstore-kafka</artifactId>
<version>0.4.0</version>
<version>0.4.3</version>
</dependency>
```
2. Added extensions `src/main/resources/META-INF/services/javax.enterprise.inject.spi.Extension`
Expand Down
7 changes: 4 additions & 3 deletions examples/00-installation.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,14 @@ Installation steps needs to be done prior the development.
```bash
docker network create eventstore

docker run -d --name es-zk --net eventstore -p 7072:7072 zookeeper:3.4.12
docker run -d --name es-zk --net eventstore -p 7072:7072 zookeeper:3.5.5

docker run -d --name es-kafka --net eventstore -p 9092:9092 -e KAFKA_ZOOKEEPER_CONNECT=es-zk:2181 \
-e KAFKA_ADVERTISED_LISTENERS=PLAINTEXT://localhost:9092 -e KAFKA_BROKER_ID=0 \
-e KAFKA_NUM_PARTITIONS=32 -e KAFKA_LOG_RETENTION_MS=-1 -e KAFKA_COMPRESSION_TYPE=gzip \
-e KAFKA_DELETE_TOPIC_ENABLE=false -e KAFKA_LOG_CLEANUP_POLICY=compact \
-e KAFKA_OFFSETS_TOPIC_REPLICATION_FACTOR=1 -e KAFKA_HEAP_OPTS="-Xmx512m -Xms512m" confluentinc/cp-kafka:4.1.1
-e KAFKA_OFFSETS_TOPIC_REPLICATION_FACTOR=1 -e KAFKA_HEAP_OPTS="-Xmx512m -Xms512m" \
-e CONFLUENT_SUPPORT_METRICS_ENABLE=false confluentinc/cp-kafka:5.3.0

docker exec es-kafka kafka-topics --zookeeper=es-zk:2181 --list

Expand All @@ -36,4 +37,4 @@ docker exec es-kafka kafka-streams-application-reset --application-id client-app

docker exec es-kafka kafka-run-class kafka.tools.GetOffsetShell --broker-list localhost:9092 --topic eventstore

```
```
2 changes: 1 addition & 1 deletion examples/01-todolist/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@ Queries:
* Get all ToDos
```bash
curl http://localhost:9080/api/todo
```
```
4 changes: 2 additions & 2 deletions examples/01-todolist/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<dependency>
<groupId>net.osomahe</groupId>
<artifactId>eventstore-kafka</artifactId>
<version>0.4.0-SNAPSHOT</version>
<version>0.5.0-SNAPSHOT</version>
</dependency>
</dependencies>
<build>
Expand All @@ -26,4 +26,4 @@
<maven.compiler.target>1.8</maven.compiler.target>
<failOnMissingWebXml>false</failOnMissingWebXml>
</properties>
</project>
</project>
4 changes: 4 additions & 0 deletions examples/01-todolist/src/main/webapp/WEB-INF/jboss-webx.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<jboss-web>
<context-root>/</context-root>
</jboss-web>
21 changes: 20 additions & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
<dependency>
<groupId>org.apache.kafka</groupId>
<artifactId>kafka-clients</artifactId>
<version>2.0.0</version>
<version>2.3.0</version>
</dependency>

<dependency>
Expand Down Expand Up @@ -130,4 +130,23 @@
</build>
</profile>
</profiles>
<build>
<plugins>
<plugin>
<groupId>org.owasp</groupId>
<artifactId>dependency-check-maven</artifactId>
<version>5.2.0</version>
<configuration>
<failBuildOnCVSS>8</failBuildOnCVSS>
</configuration>
<executions>
<execution>
<goals>
<goal>check</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins>
</build>
</project>
6 changes: 0 additions & 6 deletions src/main/resources/META-INF/beans.xml

This file was deleted.

0 comments on commit 6a67397

Please sign in to comment.