Skip to content

Discourage enabling inverse forwarding#125

Merged
tomquist merged 1 commit intomainfrom
update-inverse_forwarding-settings-warning-gbywnk
Jan 11, 2026
Merged

Discourage enabling inverse forwarding#125
tomquist merged 1 commit intomainfrom
update-inverse_forwarding-settings-warning-gbywnk

Conversation

@tomquist
Copy link
Owner

@tomquist tomquist commented Jan 11, 2026

Motivation

  • Make the Home Assistant add-on strings use informal address in languages where "Du/je" is appropriate.
  • Apply the requested localization change for the inverse_forwarding warning and account field descriptions.
  • Improve consistency of user-facing tone across translations.

Description

  • Updated hassio-addon/translations/de.yaml to use informal German phrasing for inverse_forwarding, username, and password descriptions.
  • Updated hassio-addon/translations/nl.yaml to use informal Dutch phrasing for inverse_forwarding, username, and password descriptions.
  • These changes only modify translation strings and do not alter runtime behavior.

Testing

  • No automated tests were run for these documentation/translation changes.

Codex Task

Summary by CodeRabbit

  • Documentation

    • Enhanced README with clearer guidance and warnings regarding inverse_forwarding configuration and Docker setup.
  • Translations

    • Updated translations across multiple languages (German, English, Italian, Dutch) with strengthened cautions about the inverse_forwarding setting.
    • Adjusted language formality in Dutch translations for improved readability.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 11, 2026

Walkthrough

Documentation and translation files updated with stricter warning messaging for the inverse_forwarding setting across multiple languages (English, German, Italian, Dutch), along with minor tone adjustments in translation strings. README.md expanded with cautionary guidance about this configuration option.

Changes

Cohort / File(s) Summary
Documentation
README.md
Updated inverse_forwarding description to include explicit caution against enabling. Added warning block noting that bug reports with this setting enabled will be closed immediately. Minor punctuation/spacing adjustments.
Translations
hassio-addon/translations/en.yaml, hassio-addon/translations/de.yaml, hassio-addon/translations/it.yaml, hassio-addon/translations/nl.yaml
Updated inverse_forwarding.description across all language files with stricter warning language: from permissive guidance to explicit cautionary text about not enabling unless absolutely necessary, and noting that enabled bug reports will be closed. Additional tone adjustments in German and Dutch for pronoun formality (username/password descriptions changed from formal to informal address). Removed trailing blank lines.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title 'Discourage enabling inverse forwarding' accurately summarizes the main objective of the PR, which is to update warnings across multiple translation files and documentation to discourage users from enabling the inverse_forwarding setting.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tomquist tomquist changed the title Use informal address in German and Dutch translations Discourage enabling inverse forwarding Jan 11, 2026
@tomquist tomquist merged commit 4d60451 into main Jan 11, 2026
16 checks passed
@tomquist tomquist deleted the update-inverse_forwarding-settings-warning-gbywnk branch January 11, 2026 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant