Skip to content

Commit

Permalink
Merge pull request #66 from tomoki1207/ver_1_0-endgame
Browse files Browse the repository at this point in the history
Ver 1.0
  • Loading branch information
tomoki1207 authored Jun 18, 2020
2 parents 19d8131 + 98df833 commit 4eb4591
Show file tree
Hide file tree
Showing 92 changed files with 37,499 additions and 60,816 deletions.
1 change: 1 addition & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
lib/*
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## 1.0.0 (2020/06/18)

- [Change extension API](https://github.com/microsoft/vscode/issues/77131)
- Resolve known issues about showing pdf preview.
- Upgrade PDF.js to 2.4.456

## 0.6.0 (2020/04/10)

- Support auto reload (#52)
Expand Down
26 changes: 22 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,30 @@

Display pdf in VSCode.

![screenshot](https://raw.githubusercontent.com/tomoki1207/vscode-pdfviewer/images/screenshot.png)
![screenshot](https://user-images.githubusercontent.com/3643499/84454816-98fcd600-ac96-11ea-822c-3ae1e1599a13.gif)

## Known Issues
## Important notice
Because this issue([vscode#99906](https://github.com/microsoft/vscode/issues/99906)), you can't show extensions have extension.id like `*.pdf` (includes this extension) after install this extenstion.
If you want to manage these, do it directly at pain where left of Extension View(`Cmd+Shift+x`).
![sample](https://user-images.githubusercontent.com/3643499/84976149-1e362e00-b162-11ea-950a-03061e38a83a.png)

- [ ] Displayed raw string for a moment before preview.
- [ ] Some pdf files opened as binary.
## Contribute

### Upgrade PDF.js

1. Download latest [Prebuilt](https://mozilla.github.io/pdf.js/getting_started/#download).
1. Extract the ZIP file.
1. Overwrite ./lib/* by extracted directories.
- If lib/web/viewer.html has changes, apply these changes to HTML template at pdfPreview.ts.
1. To not use sample pdf.
- Remove sample pdf called `compressed.tracemonkey-pldi-09.pdf`.
- Remove code about using sample pdf from lib/web/viewer.js.
```js
defaultUrl: {
value: "", // "compressed.tracemonkey-pldi-09.pdf"
kind: OptionKind.VIEWER
},
```

## Change log
See [CHANGELOG.md](CHANGELOG.md).
Expand Down
Loading

0 comments on commit 4eb4591

Please sign in to comment.