Open
Conversation
9e03094 to
9a3796e
Compare
Owner
|
Hello abaire, Thanks for your work, i'm happy to merge these commits to the main branch. However can you add a new section to the readme for "building on linux/mac" ? Cheers for fixing up the code! |
Author
|
Sure, added. I also have a few other fixes for issues that I've hit that you may want to incorporate (see abaire/XboxBiosTool/tree/main ). Unfortunately I ended up running clang-format over everything so they're not as cleanly PR'd as this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.