Windows 10 Anniversary Update Virtual Terminal 256 Color functionality

[AlexeiScherbakov]

Basic functionality, not integrated it Colorful.Console class
see - #24

[Alexejhero]

This pull request has not been updated since 2017. Is this still being worked on?

[AlexeiScherbakov]

Don't know. I just added code which use this feauture, I don't know Colorful.Console internals пт, 21 июн. 2019 г., 22:15 AlexejheroYTB <notifications@github.com>:

…

This pull request has not been updated since 2017. Is this still being worked on? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#29?email_source=notifications&email_token=ACCDWOZL35PK5YFWYU4UIHDP3USDRA5CNFSM4DP5EAH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYJLHIA#issuecomment-504542112>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACCDWO2WMF4ESAETSSCORSDP3USDRANCNFSM4DP5EAHQ> .

[AlexeiScherbakov]

Well it is better to rework entire library for .NET Core. As i remember, code of this project is pretty old. Today net46, netstandard2.0 and netcoreapp2.1 are needed пт, 21 июн. 2019 г., 22:58 AlexejheroYTB <notifications@github.com>:

…

If this project is no longer being maintained, I will create a NuGet package with this patch. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#29?email_source=notifications&email_token=ACCDWO7EFNBBL237J67E5UDP3UXH5A5CNFSM4DP5EAH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYJOI6Q#issuecomment-504554618>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACCDWOY6UCOBQ3SUQVILJZ3P3UXH5ANCNFSM4DP5EAHQ> .

[tomakita]

Hi @AlexeiScherbakov ,

You're right, work will need to be done to add .NET Core support. I don't have to time begin working on this yet, but it's on my list of things to do, as .NET Core 3.0 is almost upon us. I'll also accept PRs for .NET Core support :)

Hi @AlexejheroYTB ,

Thanks for the reminder. I never merged this PR because I didn't have access to Windows 10, and I was worried that I wouldn't be able to test the PR version of the code. I have Windows 10 now, and will test this out over the weekend, so that @AlexeiScherbakov 's PR doesn't go to waste.

[tomakita]

@AlexeiScherbakov

I've looked through and tested the code. It looks good, and works very well. Thanks for the PR!

I have a thought about how we can detect VT support, though: I'm thinking that, rather than using operating system detection, we should just try to detect whether or not the feature is available. This might work better if e.g. VT support is removed in later versions of Windows. Your code already does this -- I'll add a bit more code once you merge this PR, but your code does most of what we'll need to do. So if we go this route of feature detection instead of operating system detection, I think we can remove the OperationSystemDetector class. We could also remove lines 23-34 (inclusive) from NativeMethods.cs. What do you think?

BTW, you don't have to make these changes, I can make them after I merge the PR.

[0xF6]

wtf?
Please, use RuntimeInformation.IsOSPlatform()

[Eregrith]

@tomakita Are you planning to expose a capability-test function to clients of the lib? It would be useless to allow 256 colors but not tell the dev if more than 16 colors can be safely used in the style config because it would render very ugly when not 256-capable and configured colors start to overflow the 16 buffer :/

[tomakita]

@Eregrith That's the plan, though it hasn't yet been decided exactly how that will be implemented. See #29 (comment) for more info.

Btw, I'm very much open to PRs in this area (perhaps one that is based upon Alexei's good work in this PR). I haven't merged this one because there's more work to be done in order to make it prod ready, and I haven't had the time to do it, yet.

[NotoriousRebel]

any updates?

[dotnetshadow]

Any chance to get this merged in?