io: implemented get_ref and get_mut for SyncIoBridge
#7128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darksonn
reviewed
Jan 27, 2025
Co-authored-by: Alice Ryhl <[email protected]>
Darksonn
reviewed
Jan 27, 2025
tokio-util/src/io/sync_bridge.rs
Outdated
Comment on lines
157
to
169
| /// Returns a shared reference to the inner resource. | ||
| /// | ||
| /// It is inadvisable to directly read/write from the underlying resource. | ||
| pub fn get_ref(&self) -> &T { | ||
| &self.src | ||
| } | ||
|
|
||
| /// Returns a mutable reference to the inner resource. | ||
| /// | ||
| /// It is inadvisable to directly read/write from the underlying resource. | ||
| pub fn get_mut(&mut self) -> &mut T { | ||
| &mut self.src | ||
| } |
There was a problem hiding this comment.
We probably should use the AsRef/AsMut traits instead? I think we do that in most places where we provide accessor to the inner value.
There was a problem hiding this comment.
There's precedent for both (Framed for example offers explicit get_{ref,mut} methods, whereas stream_wrappers implement {AsMut,AsRef}).
I now switched to implement the traits instead here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When interacting with resources wrapped in a
SyncIoBridge, it might be handy to interact with the inner resource.Solution
Implement
get_refandget_mutonSyncIoBridge.