Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT RFC: limited no-std I/O support using portable-io #7102

Closed
wants to merge 19 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions tokio/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@ categories = ["asynchronous", "network-programming"]
keywords = ["io", "async", "non-blocking", "futures"]

[features]
# Include nothing by default
default = []
default = ["std"]

# enable everything
full = [
Expand All @@ -37,16 +36,18 @@ full = [
"rt",
"rt-multi-thread",
"signal",
"std",
"sync",
"time",
]

fs = []
fs = ["std"]
io-util = ["bytes"]
# stdin, stdout, stderr
io-std = []
macros = ["tokio-macros"]
io-std = ["std"]
macros = ["std", "tokio-macros"]
net = [
"std",
"libc",
"mio/os-poll",
"mio/os-ext",
Expand All @@ -58,7 +59,9 @@ net = [
"windows-sys/Win32_System_Pipes",
"windows-sys/Win32_System_SystemServices",
]
portable-io = ["parking_lot", "dep:portable-io"]
process = [
"std",
"bytes",
"libc",
"mio/os-poll",
Expand All @@ -70,9 +73,10 @@ process = [
"windows-sys/Win32_System_WindowsProgramming",
]
# Includes basic task execution capabilities
rt = []
rt = ["std"]
rt-multi-thread = ["rt"]
signal = [
"std",
"libc",
"mio/os-poll",
"mio/net",
Expand All @@ -81,9 +85,10 @@ signal = [
"windows-sys/Win32_Foundation",
"windows-sys/Win32_System_Console",
]
sync = []
std = []
sync = ["std"]
test-util = ["rt", "sync", "time"]
time = []
time = ["std"]

[dependencies]
tokio-macros = { version = "~2.5.0", path = "../tokio-macros", optional = true }
Expand All @@ -94,6 +99,7 @@ pin-project-lite = "0.2.11"
bytes = { version = "1.1.0", optional = true }
mio = { version = "1.0.1", optional = true, default-features = false }
parking_lot = { version = "0.12.0", optional = true }
portable-io = { version = "0.0.4", optional = true }

[target.'cfg(not(target_family = "wasm"))'.dependencies]
socket2 = { version = "0.5.5", optional = true, features = ["all"] }
Expand Down
2 changes: 2 additions & 0 deletions tokio/src/blocking.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ cfg_rt! {
}

cfg_not_rt! {
use crate::alias::std;

use std::fmt;
use std::future::Future;
use std::pin::Pin;
Expand Down
1 change: 1 addition & 0 deletions tokio/src/fs/canonicalize.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
use crate::alias::std::{self, prelude::*};
use crate::fs::asyncify;

use std::io;
Expand Down
1 change: 1 addition & 0 deletions tokio/src/fs/copy.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
use crate::alias::std::{self, prelude::*};
use crate::fs::asyncify;
use std::path::Path;

Expand Down
1 change: 1 addition & 0 deletions tokio/src/fs/create_dir.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
use crate::alias::std::{self, prelude::*};
use crate::fs::asyncify;

use std::io;
Expand Down
1 change: 1 addition & 0 deletions tokio/src/fs/create_dir_all.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
use crate::alias::std::{self, prelude::*};
use crate::fs::asyncify;

use std::io;
Expand Down
1 change: 1 addition & 0 deletions tokio/src/fs/dir_builder.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
use crate::alias::std::{self, prelude::*};
use crate::fs::asyncify;

use std::io;
Expand Down
1 change: 1 addition & 0 deletions tokio/src/fs/file.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
//!
//! [`File`]: File

use crate::alias::std::{self, prelude::*};
use crate::fs::{asyncify, OpenOptions};
use crate::io::blocking::{Buf, DEFAULT_MAX_BUF_SIZE};
use crate::io::{AsyncRead, AsyncSeek, AsyncWrite, ReadBuf};
Expand Down
1 change: 1 addition & 0 deletions tokio/src/fs/hard_link.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
use crate::alias::std::{self, prelude::*};
use crate::fs::asyncify;

use std::io;
Expand Down
1 change: 1 addition & 0 deletions tokio/src/fs/metadata.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
use crate::alias::std::{self, prelude::*};
use crate::fs::asyncify;

use std::fs::Metadata;
Expand Down
2 changes: 1 addition & 1 deletion tokio/src/fs/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ cfg_windows! {
pub use self::symlink_file::symlink_file;
}

use std::io;
use crate::alias::std::io;

#[cfg(not(test))]
use crate::blocking::spawn_blocking;
Expand Down
1 change: 1 addition & 0 deletions tokio/src/fs/open_options.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
use crate::alias::std::{self, prelude::*};
use crate::fs::{asyncify, File};

use std::io;
Expand Down
1 change: 1 addition & 0 deletions tokio/src/fs/read.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
use crate::alias::std::{self, prelude::*};
use crate::fs::asyncify;

use std::{io, path::Path};
Expand Down
1 change: 1 addition & 0 deletions tokio/src/fs/read_dir.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
use crate::alias::std::{self, prelude::*};
use crate::fs::asyncify;

use std::collections::VecDeque;
Expand Down
1 change: 1 addition & 0 deletions tokio/src/fs/read_link.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
use crate::alias::std::{self, prelude::*};
use crate::fs::asyncify;

use std::io;
Expand Down
1 change: 1 addition & 0 deletions tokio/src/fs/read_to_string.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
use crate::alias::std::{self, prelude::*};
use crate::fs::asyncify;

use std::{io, path::Path};
Expand Down
1 change: 1 addition & 0 deletions tokio/src/fs/remove_dir.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
use crate::alias::std::{self, prelude::*};
use crate::fs::asyncify;

use std::io;
Expand Down
1 change: 1 addition & 0 deletions tokio/src/fs/remove_dir_all.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
use crate::alias::std::{self, prelude::*};
use crate::fs::asyncify;

use std::io;
Expand Down
1 change: 1 addition & 0 deletions tokio/src/fs/remove_file.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
use crate::alias::std::{self, prelude::*};
use crate::fs::asyncify;

use std::io;
Expand Down
1 change: 1 addition & 0 deletions tokio/src/fs/rename.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
use crate::alias::std::{self, prelude::*};
use crate::fs::asyncify;

use std::io;
Expand Down
1 change: 1 addition & 0 deletions tokio/src/fs/set_permissions.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
use crate::alias::std::{self, prelude::*};
use crate::fs::asyncify;

use std::fs::Permissions;
Expand Down
1 change: 1 addition & 0 deletions tokio/src/fs/symlink.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
use crate::alias::std::{self, prelude::*};
use crate::fs::asyncify;

use std::io;
Expand Down
1 change: 1 addition & 0 deletions tokio/src/fs/symlink_metadata.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
use crate::alias::std::{self, prelude::*};
use crate::fs::asyncify;

use std::fs::Metadata;
Expand Down
1 change: 1 addition & 0 deletions tokio/src/fs/try_exists.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
use crate::alias::std::{self, prelude::*};
use crate::fs::asyncify;

use std::io;
Expand Down
1 change: 1 addition & 0 deletions tokio/src/fs/write.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
use crate::alias::std::{self, prelude::*};
use crate::fs::asyncify;

use std::{io, path::Path};
Expand Down
2 changes: 2 additions & 0 deletions tokio/src/future/block_on.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
use crate::alias::std;

use std::future::Future;

cfg_rt! {
Expand Down
6 changes: 6 additions & 0 deletions tokio/src/future/maybe_done.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
//! Definition of the [`MaybeDone`] combinator.

use crate::alias::std;

use pin_project_lite::pin_project;
use std::future::{Future, IntoFuture};
use std::pin::Pin;
Expand Down Expand Up @@ -74,11 +76,15 @@ impl<Fut: Future> Future for MaybeDone<Fut> {
// Test for https://github.com/tokio-rs/tokio/issues/6729
#[cfg(test)]
mod miri_tests {
extern crate std;
use std::borrow::ToOwned;

use super::maybe_done;

use std::{
future::Future,
pin::Pin,
string::String,
sync::Arc,
task::{Context, Poll, Wake},
};
Expand Down
2 changes: 1 addition & 1 deletion tokio/src/future/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,6 @@ cfg_trace! {

cfg_not_trace! {
cfg_rt! {
pub(crate) use std::future::Future;
pub(crate) use crate::alias::std::future::Future;
}
}
1 change: 1 addition & 0 deletions tokio/src/future/try_join.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
use crate::alias::std;
use crate::future::maybe_done::{maybe_done, MaybeDone};

use pin_project_lite::pin_project;
Expand Down
3 changes: 3 additions & 0 deletions tokio/src/io/async_buf_read.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
use crate::alias::std;
use crate::alias::std::prelude::*;

use crate::io::AsyncRead;

use std::io;
Expand Down
1 change: 1 addition & 0 deletions tokio/src/io/async_fd.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
use crate::alias::std;
use crate::io::{Interest, Ready};
use crate::runtime::io::{ReadyEvent, Registration};
use crate::runtime::scheduler;
Expand Down
4 changes: 4 additions & 0 deletions tokio/src/io/async_read.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
use super::ReadBuf;

use crate::alias::std;
use crate::alias::std::prelude::*;

use std::io;
use std::ops::DerefMut;
use std::pin::Pin;
Expand Down
3 changes: 3 additions & 0 deletions tokio/src/io/async_seek.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
use crate::alias::std;
use crate::alias::std::prelude::*;

use std::io::{self, SeekFrom};
use std::ops::DerefMut;
use std::pin::Pin;
Expand Down
3 changes: 3 additions & 0 deletions tokio/src/io/async_write.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
use crate::alias::std;
use crate::alias::std::prelude::*;

use std::io::{self, IoSlice};
use std::ops::DerefMut;
use std::pin::Pin;
Expand Down
3 changes: 3 additions & 0 deletions tokio/src/io/blocking.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
use crate::alias::std;
use crate::alias::std::prelude::*;

use crate::io::sys;
use crate::io::{AsyncRead, AsyncWrite, ReadBuf};

Expand Down
1 change: 1 addition & 0 deletions tokio/src/io/interest.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#![cfg_attr(not(feature = "net"), allow(dead_code, unreachable_pub))]

use crate::alias::std;
use crate::io::ready::Ready;

use std::fmt;
Expand Down
1 change: 1 addition & 0 deletions tokio/src/io/join.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
//! Join two values implementing `AsyncRead` and `AsyncWrite` into a single one.

use crate::alias::std;
use crate::io::{AsyncBufRead, AsyncRead, AsyncWrite, ReadBuf};

use std::io;
Expand Down
2 changes: 2 additions & 0 deletions tokio/src/io/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,8 @@ cfg_io_blocking! {
pub(crate) mod blocking;
}

use crate::alias::std;

mod async_buf_read;
pub use self::async_buf_read::AsyncBufRead;

Expand Down
1 change: 1 addition & 0 deletions tokio/src/io/poll_evented.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
use crate::alias::std;
use crate::io::interest::Interest;
use crate::runtime::io::Registration;
use crate::runtime::scheduler;
Expand Down
2 changes: 2 additions & 0 deletions tokio/src/io/read_buf.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
use crate::alias::std;

use std::fmt;
use std::mem::MaybeUninit;

Expand Down
1 change: 1 addition & 0 deletions tokio/src/io/ready.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#![cfg_attr(not(feature = "net"), allow(unreachable_pub))]

use crate::alias::std;
use crate::io::interest::Interest;

use std::fmt;
Expand Down
1 change: 1 addition & 0 deletions tokio/src/io/seek.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
use crate::alias::std;
use crate::io::AsyncSeek;

use pin_project_lite::pin_project;
Expand Down
19 changes: 19 additions & 0 deletions tokio/src/io/split.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,19 @@
//! To restore this read/write object from its `split::ReadHalf` and
//! `split::WriteHalf` use `unsplit`.

use crate::alias::std;
use crate::io::{AsyncRead, AsyncWrite, ReadBuf};

use std::fmt;
use std::io;
use std::pin::Pin;
use std::sync::Arc;
#[cfg(all(
feature = "parking_lot",
not(feature = "std"),
))]
use parking_lot::Mutex;
#[cfg(feature = "std")]
use std::sync::Mutex;
use std::task::{Context, Poll};

Expand Down Expand Up @@ -57,6 +64,12 @@ struct Inner<T> {

impl<T> Inner<T> {
fn with_lock<R>(&self, f: impl FnOnce(Pin<&mut T>) -> R) -> R {
#[cfg(all(
feature = "parking_lot",
not(feature = "std"),
))]
let mut guard = self.stream.lock();
#[cfg(feature = "std")]
let mut guard = self.stream.lock().unwrap();

// safety: we do not move the stream.
Expand Down Expand Up @@ -92,6 +105,12 @@ impl<T> ReadHalf<T> {
.ok()
.expect("`Arc::try_unwrap` failed");

#[cfg(all(
feature = "parking_lot",
not(feature = "std"),
))]
return inner.stream.into_inner();
#[cfg(feature = "std")]
inner.stream.into_inner().unwrap()
} else {
panic!("Unrelated `split::Write` passed to `split::Read::unsplit`.")
Expand Down
3 changes: 3 additions & 0 deletions tokio/src/io/stderr.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
use crate::alias::std;
use crate::io::blocking::Blocking;
use crate::io::stdio_common::SplitByUtf8BoundaryIfWindows;
use crate::io::AsyncWrite;
Expand Down Expand Up @@ -79,6 +80,8 @@ cfg_io_std! {

#[cfg(unix)]
mod sys {
use crate::alias::std;

use std::os::unix::io::{AsFd, AsRawFd, BorrowedFd, RawFd};

use super::Stderr;
Expand Down
Loading
Loading