util: simplify ReusableBoxFuture::try_set logic
#7057
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yukibtc
force-pushed
the
simplify-reusable-box
branch
from
fe96b41 to
314b5e5
Compare
Darksonn
reviewed
Dec 31, 2024
| // future::Pending<T> is a ZST so this never allocates. | ||
| let boxed = mem::replace(&mut this.boxed, Box::pin(future::pending())); | ||
| reuse_pin_box(boxed, future, |boxed| this.boxed = Pin::from(boxed)) | ||
| self.boxed = Box::pin(future); |
There was a problem hiding this comment.
The point of ReusableBoxFuture is to reuse the Box, but this appears to create a new box?
There was a problem hiding this comment.
Yeah, sorry, my bad. I'm going to close this
Darksonn
added
A-tokio-util
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Most of the code related to the
ReusableBoxFuture::try_setis complex and unsafe.Solution
Remove the
reuse_pin_boxfunction and check directly if the provided future has a different size or alignment from the currently stored withmem::size_of_valandmem::align_of_val.