chore: Update dependencies and fix clippy warnings #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to rust-lang/rust#124210, when an owned fd has already been closed before it's dropped means that something else touched the fd in ways its not allowed to. Therefore, these tests fail due to this new behavior enforcement Signed-off-by: Bryant Biggs <[email protected]>
|
cc @Noah-Kennedy if you have a few cycles to review |
|
Drive-by review: I don't think bumping patch versions of dependencies makes sense unless the older versions have a serious security vulnerability, are completely broken or break |
|
@paolobarbolini what are the downsides of bumping the patch versions? |
The inflexibility of not being able to update things at my own pace, which for me personally I try to update things frequently, but if I have to revert to a previous version I don't want to have to downgrade or fork a second dependency just because the minimum allowed version was bumped too high. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
due to this new behavior enforcement
CI tests were executed on fork first to ensure tests pass https://github.com/bryantbiggs/tokio-uring/actions/runs/14344438841?pr=1
Closes #324
Closes #313
Closes #272
Resolves #316