Skip to content

impl From<Bytes> and From<Vec<u8>> for BytesMut #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

impl From<Bytes> and From<Vec<u8>> for BytesMut #492

wants to merge 1 commit into from

Conversation

@stepancheg
Copy link
Contributor

From<Bytes> implementation is suboptimal: can be optimized for
certain representations of Bytes.

@stepancheg
impl From<Bytes> and From<Vec<u8>> for BytesMut
599d089 
`From<Bytes>` implementation is suboptimal: can be optimized for
certain representations of `Bytes`.
@stepancheg stepancheg force-pushed the bytes-mut-from-bytes branch from 865ebcd to 599d089 Compare March 28, 2021 16:25
@stepancheg stepancheg changed the title impl From<Bytes> anf From<Vec<u8>> for BytesMut impl From<Bytes> and From<Vec<u8>> for BytesMut Mar 28, 2021
@taiki-e
Copy link
Member

taiki-e commented Apr 10, 2021

I think it's intentional that From<Vec<u8>> has not been provided. See also previous discussion: #414

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stepancheg @taiki-e