This repository was archived by the owner on Feb 13, 2024. It is now read-only.
[LibOverhaul 06] Mark override methods #3341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinBriza
force-pushed
the
fix/library-overhaul/rebased/06-mark-override-methods
branch
from
0f8be36 to
eacb1cf
Compare
|
The change of this PR is toggl@eacb1cf and it works well in macOS / Windows by playing around the app. However, this PR is children of the JSON PR, which has 1 issue. Therefore, I will approve but not merge until the host is properly addressed. 👍 |
MartinBriza
force-pushed
the
fix/library-overhaul/rebased/06-mark-override-methods
branch
from
eacb1cf to
61b6e53
Compare
MartinBriza
deleted the
fix/library-overhaul/rebased/06-mark-override-methods
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📒 Description
It's better to mark overriden virtual methods in child classes to avoid mixups when changing the underlying API or to just be sure that we're working with a virtual method in the child class.
🕶️ Types of changes
🔎 Review hints