Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(editor): refactor page note empty checker #9570

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

L-Sun
Copy link
Contributor

@L-Sun L-Sun commented Jan 7, 2025

Close BS-2320

Copy link
Contributor Author

L-Sun commented Jan 7, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the test Related to test cases label Jan 7, 2025
@L-Sun L-Sun force-pushed the l-sun/refactor/page-note-empty-checker branch from fe799a3 to 498164b Compare January 7, 2025 10:18
@L-Sun L-Sun changed the title test(editor): add test to doc empty checker refactor(editor): refactor page note empty checker Jan 7, 2025
@L-Sun L-Sun marked this pull request as ready for review January 7, 2025 10:18
@L-Sun L-Sun requested a review from a team as a code owner January 7, 2025 10:18
@graphite-app graphite-app bot requested a review from forehalo January 7, 2025 10:18
@L-Sun L-Sun requested review from Saul-Mirone and CatsJuice January 7, 2025 10:24
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 68.18182% with 7 lines in your changes missing coverage. Please review.

Project coverage is 52.76%. Comparing base (482b534) to head (4402398).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...suite/presets/src/fragments/doc-title/doc-title.ts 0.00% 4 Missing ⚠️
...cksuite/affine/model/src/blocks/note/note-model.ts 83.33% 0 Missing and 1 partial ⚠️
...ine/shared/src/utils/dnd/get-drop-rect-by-point.ts 0.00% 1 Missing ⚠️
...ite/framework/store/src/model/block/block-model.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9570      +/-   ##
==========================================
+ Coverage   52.71%   52.76%   +0.05%     
==========================================
  Files        2167     2167              
  Lines       97432    97442      +10     
  Branches    16232    16241       +9     
==========================================
+ Hits        51357    51411      +54     
+ Misses      44712    44662      -50     
- Partials     1363     1369       +6     
Flag Coverage Δ
server-test 78.13% <ø> (ø)
unittest 32.35% <63.63%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Saul-Mirone Saul-Mirone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

graphite-app bot commented Jan 7, 2025

Merge activity

@L-Sun L-Sun force-pushed the l-sun/refactor/page-note-empty-checker branch from 23d9551 to 4402398 Compare January 7, 2025 11:24
@graphite-app graphite-app bot merged commit 4402398 into canary Jan 7, 2025
61 checks passed
@graphite-app graphite-app bot deleted the l-sun/refactor/page-note-empty-checker branch January 7, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants