Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): client version check #9205

Open
wants to merge 7 commits into
base: canary
Choose a base branch
from
Open

Conversation

darkskygit
Copy link
Member

No description provided.

@github-actions github-actions bot added app:server test Related to test cases labels Dec 19, 2024
Copy link
Member Author

darkskygit commented Dec 19, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 98.45361% with 3 lines in your changes missing coverage. Please review.

Project coverage is 51.95%. Comparing base (aacdb71) to head (f95fbe9).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
packages/backend/server/src/base/guard/guard.ts 90.00% 0 Missing and 1 partial ⚠️
packages/backend/server/src/core/version/guard.ts 97.50% 1 Missing ⚠️
...ackages/backend/server/src/core/version/service.ts 98.52% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9205      +/-   ##
==========================================
- Coverage   52.02%   51.95%   -0.08%     
==========================================
  Files        2136     2140       +4     
  Lines       97366    97565     +199     
  Branches    16670    16658      -12     
==========================================
+ Hits        50651    50686      +35     
- Misses      45372    45512     +140     
- Partials     1343     1367      +24     
Flag Coverage Δ
server-test 78.32% <98.45%> (-0.41%) ⬇️
unittest 30.94% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Brooooooklyn Brooooooklyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some tests

@darkskygit darkskygit force-pushed the darksky/version-check branch 2 times, most recently from 1e876b8 to 6de0745 Compare December 19, 2024 09:47
}
}

async checkVersion(clientVersion?: any) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might need the channel control, cross channel connections should be forbidden

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:server test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants