Skip to content

Conversation

ppannuto
Copy link
Member

Untested.

Inspired by the recent MPU configuration bug, here is a MPU test that is 'bare metal', i.e. would not be saved by the implicit sbrk in Tock's libc startup. Note, that this specific test would not actually catch the issue — this currently provides coverage of everything that the app should access without fault. But the goal is to provide complete coverage of the 'good cases' and be easy to modify for specific test cases.

@lschuermann
Copy link
Member

lschuermann commented Jun 13, 2025

@ppannuto How should we move forward on this? Are you still planning on doing some more testing, should someone else do that, or should we just merge?

I'm happy to offer testing on the RISC-V side.

@ppannuto
Copy link
Member Author

I believe that @tyler-potyondy and @vrindisbacher tested this fairly extensively working on #4384. I think this is probably just good to merge.

@alevy alevy added this pull request to the merge queue Jun 13, 2025
Merged via the queue into master with commit 9a1b6d2 Jun 13, 2025
4 checks passed
@alevy alevy deleted the mpu_no_libc branch June 13, 2025 22:55
@lschuermann
Copy link
Member

@tyler-potyondy @vrindisbacher Did you also test this on RISC-V?

@vrindisbacher
Copy link

I didn't test on RISC-V but I have been working on verifying the RISC-V implementation. I already verified the allocate app memory region method and it seems free of bugs.

@lschuermann
Copy link
Member

Cool, that's good to hear 😅. I'll put it on my todo list to run this app on RISC-V, just to make sure we won't be surprised later if the test app itself somehow was incorrect.

@lschuermann
Copy link
Member

@vrindisbacher @ppannuto This seems to almost work on RISC-V, apart from one error that I believe should also affect Cortex-M. Fix and discussion thread for that in #535.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants