Replace Bun.spawnSync + realpath with fs.realpathSync to improve index file performance on 14k documents. #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big fan of your work Tobi, this is very cool!
Issue / Reproduction
QMD is installed globally on a M1 MacBook Pro, with Ghostty.
Running
qmd addon a folder with a 14k file subdirectory hangs the qmd process. I isolated this down to theBun.spawnSync(["realpath", path]);call on line 119.Running realpath in the same dir with the small bash script below works. Running
Bun.spawnSyncwithrealpathdoes not.I also tried
Bun.spawnSyncwith thestatcommand and that worked correctly.This commit just changes line 119 to a Bun native
fs.realpathSync.Before commit
After commit