Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for agent forwarding #206

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adamdunkley
Copy link

I literally haven't even had the chance to run this, so sorry if something is logically wrong … but I thought it would at least get the ball rolling, it's not a complex change now fabric is updated

Fixes #59

@@ -376,7 +376,7 @@ def _configure_node():
if env.loglevel == "debug":
print("Executing Chef Solo with the following command:\n"
"{0}".format(cmd))
with settings(hide('warnings', 'running'), warn_only=True):
with settings(hide('warnings', 'running'), warn_only=True, forward_agent=forward_agent):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess if you want to forward the ssh agent you will want that to happen for all ssh operations, not just when calling chef-solo.
Therefore, we need to set it globally in runner.py.

The other missing piece is in adding the actual command line option to fix

@tobami
Copy link
Owner

tobami commented Jan 9, 2015

@adamdunkley hi, do you plan to address the comments so we can merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ssh ForwardAgent
2 participants