Add utility to construct artificial interest fields from detected features#566
Open
Sven-248 wants to merge 4 commits intotobac-project:RC_v1.6.xfrom
Open
Add utility to construct artificial interest fields from detected features#566Sven-248 wants to merge 4 commits intotobac-project:RC_v1.6.xfrom
Sven-248 wants to merge 4 commits intotobac-project:RC_v1.6.xfrom
Conversation
Linting results by Pylint:Your code has been rated at 8.36/10 (previous run: 8.37/10, -0.01) |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## RC_v1.6.x #566 +/- ##
=============================================
+ Coverage 64.86% 65.01% +0.14%
=============================================
Files 27 28 +1
Lines 4047 4110 +63
=============================================
+ Hits 2625 2672 +47
- Misses 1422 1438 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR handles #540 and introduces a new utility function features_to_interest_field that reconstructs an artificial interest field from a feature table (e.g. output of tobac feature detection).
The function places blobs at the detected feature positions and generates a corresponding field on a given template grid. Blob amplitude can be derived from a feature property and blob size can be estimated from feature area.