Added Client Type feature flag to begin client type work (keycloak#26389

) * Added Client Type feature flag to begin client type work Closes keycloak#26346 Signed-off-by: vibrown <[email protected]> * Fixed formatting issue Signed-off-by: vibrown <[email protected]> * Updated HelpCommandDistTest messages Signed-off-by: vibrown <[email protected]> * Fixed formatting on HelpCommandDistTest messages Signed-off-by: vibrown <[email protected]> --------- Signed-off-by: vibrown <[email protected]>
tnorimat · Jan 24, 2024 · 8609824 · 8609824
1 parent 142c141
commit 8609824
Show file tree

Hide file tree

Showing 18 changed files with 115 additions and 97 deletions.
diff --git a/common/src/main/java/org/keycloak/common/Profile.java b/common/src/main/java/org/keycloak/common/Profile.java
@@ -104,6 +104,8 @@ public enum Feature {
 
         MULTI_SITE("Multi-site support", Type.PREVIEW),
 
+        CLIENT_TYPES("Client Types", Type.EXPERIMENTAL),
+
         OFFLINE_SESSION_PRELOADING("Offline session preloading", Type.DEPRECATED),
 
         HOSTNAME_V1("Hostname Options V1", Type.DEFAULT),

diff --git a/common/src/test/java/org/keycloak/common/ProfileTest.java b/common/src/test/java/org/keycloak/common/ProfileTest.java
@@ -85,7 +85,8 @@ public void checkDefaults() {
             Profile.Feature.CLIENT_SECRET_ROTATION,
             Profile.Feature.UPDATE_EMAIL,
             Profile.Feature.LINKEDIN_OAUTH,
-            Profile.Feature.OFFLINE_SESSION_PRELOADING
+            Profile.Feature.OFFLINE_SESSION_PRELOADING,
+            Profile.Feature.CLIENT_TYPES
         ));
 
         // KERBEROS can be disabled (i.e. FIPS mode disables SunJGSS provider)

diff --git a/js/apps/admin-ui/src/context/server-info/__tests__/mock.json b/js/apps/admin-ui/src/context/server-info/__tests__/mock.json
@@ -39,7 +39,8 @@
       "SCRIPTS",
       "OPENSHIFT_INTEGRATION",
       "ADMIN_FINE_GRAINED_AUTHZ",
-      "TOKEN_EXCHANGE"
+      "TOKEN_EXCHANGE",
+      "CLIENT_TYPES"
     ],
     "previewFeatures": [
       "DECLARATIVE_USER_PROFILE",
@@ -48,7 +49,7 @@
       "ADMIN_FINE_GRAINED_AUTHZ",
       "TOKEN_EXCHANGE"
     ],
-    "experimentalFeatures": ["ADMIN2", "MAP_STORAGE", "DYNAMIC_SCOPES"]
+    "experimentalFeatures": ["ADMIN2", "MAP_STORAGE", "DYNAMIC_SCOPES", "CLIENT_TYPES"]
   },
   "themes": {
     "common": [{ "name": "keycloak" }],

diff --git a/js/apps/admin-ui/src/utils/useIsFeatureEnabled.ts b/js/apps/admin-ui/src/utils/useIsFeatureEnabled.ts
@@ -8,6 +8,7 @@ export enum Feature {
   DPoP = "DPOP",
   DeviceFlow = "DEVICE_FLOW",
   TransientUsers = "TRANSIENT_USERS",
+  ClientTypes = "CLIENT_TYPES",
 }
 
 export default function useIsFeatureEnabled() {

diff --git a/...ycloak/it/cli/dist/approvals/cli/help/HelpCommandDistTest.testBuildHelp.unix.approved.txt b/...ycloak/it/cli/dist/approvals/cli/help/HelpCommandDistTest.testBuildHelp.unix.approved.txt
@@ -64,16 +64,17 @@ Feature:
 --features <feature> Enables a set of one or more features. Possible values are: account-api[:v1],
                        account2[:v1], account3[:v1], admin-api[:v1], admin-fine-grained-authz[:v1],
                        admin2[:v1], authorization[:v1], ciba[:v1], client-policies[:v1],
-                       client-secret-rotation[:v1], declarative-ui[:v1], device-flow[:v1], docker[:
-                       v1], dpop[:v1], dynamic-scopes[:v1], fips[:v1], hostname[:v1], impersonation
-                       [:v1], js-adapter[:v1], kerberos[:v1], linkedin-oauth[:v1], multi-site[:v1],
-                       offline-session-preloading[:v1], par[:v1], preview, recovery-codes[:v1],
-                       scripts[:v1], step-up-authentication[:v1], token-exchange[:v1],
-                       transient-users[:v1], update-email[:v1], web-authn[:v1].
+                       client-secret-rotation[:v1], client-types[:v1], declarative-ui[:v1],
+                       device-flow[:v1], docker[:v1], dpop[:v1], dynamic-scopes[:v1], fips[:v1],
+                       hostname[:v1], impersonation[:v1], js-adapter[:v1], kerberos[:v1],
+                       linkedin-oauth[:v1], multi-site[:v1], offline-session-preloading[:v1], par[:
+                       v1], preview, recovery-codes[:v1], scripts[:v1], step-up-authentication[:
+                       v1], token-exchange[:v1], transient-users[:v1], update-email[:v1], web-authn
+                       [:v1].
 --features-disabled <feature>
                      Disables a set of one or more features. Possible values are: account-api,
                        account2, account3, admin-api, admin-fine-grained-authz, admin2,
-                       authorization, ciba, client-policies, client-secret-rotation,
+                       authorization, ciba, client-policies, client-secret-rotation, client-types,
                        declarative-ui, device-flow, docker, dpop, dynamic-scopes, fips,
                        impersonation, js-adapter, kerberos, linkedin-oauth, multi-site,
                        offline-session-preloading, par, preview, recovery-codes, scripts,

diff --git a/...oak/it/cli/dist/approvals/cli/help/HelpCommandDistTest.testBuildHelp.windows.approved.txt b/...oak/it/cli/dist/approvals/cli/help/HelpCommandDistTest.testBuildHelp.windows.approved.txt
@@ -64,16 +64,17 @@ Feature:
 --features <feature> Enables a set of one or more features. Possible values are: account-api[:v1],
                        account2[:v1], account3[:v1], admin-api[:v1], admin-fine-grained-authz[:v1],
                        admin2[:v1], authorization[:v1], ciba[:v1], client-policies[:v1],
-                       client-secret-rotation[:v1], declarative-ui[:v1], device-flow[:v1], docker[:
-                       v1], dpop[:v1], dynamic-scopes[:v1], fips[:v1], hostname[:v1], impersonation
-                       [:v1], js-adapter[:v1], kerberos[:v1], linkedin-oauth[:v1], multi-site[:v1],
-                       offline-session-preloading[:v1], par[:v1], preview, recovery-codes[:v1],
-                       scripts[:v1], step-up-authentication[:v1], token-exchange[:v1],
-                       transient-users[:v1], update-email[:v1], web-authn[:v1].
+                       client-secret-rotation[:v1], client-types[:v1], declarative-ui[:v1],
+                       device-flow[:v1], docker[:v1], dpop[:v1], dynamic-scopes[:v1], fips[:v1],
+                       hostname[:v1], impersonation[:v1], js-adapter[:v1], kerberos[:v1],
+                       linkedin-oauth[:v1], multi-site[:v1], offline-session-preloading[:v1], par[:
+                       v1], preview, recovery-codes[:v1], scripts[:v1], step-up-authentication[:
+                       v1], token-exchange[:v1], transient-users[:v1], update-email[:v1], web-authn
+                       [:v1].
 --features-disabled <feature>
                      Disables a set of one or more features. Possible values are: account-api,
                        account2, account3, admin-api, admin-fine-grained-authz, admin2,
-                       authorization, ciba, client-policies, client-secret-rotation,
+                       authorization, ciba, client-policies, client-secret-rotation, client-types,
                        declarative-ui, device-flow, docker, dpop, dynamic-scopes, fips,
                        impersonation, js-adapter, kerberos, linkedin-oauth, multi-site,
                        offline-session-preloading, par, preview, recovery-codes, scripts,

diff --git a/...cloak/it/cli/dist/approvals/cli/help/HelpCommandDistTest.testExportHelp.unix.approved.txt b/...cloak/it/cli/dist/approvals/cli/help/HelpCommandDistTest.testExportHelp.unix.approved.txt
@@ -59,16 +59,17 @@ Feature:
 --features <feature> Enables a set of one or more features. Possible values are: account-api[:v1],
                        account2[:v1], account3[:v1], admin-api[:v1], admin-fine-grained-authz[:v1],
                        admin2[:v1], authorization[:v1], ciba[:v1], client-policies[:v1],
-                       client-secret-rotation[:v1], declarative-ui[:v1], device-flow[:v1], docker[:
-                       v1], dpop[:v1], dynamic-scopes[:v1], fips[:v1], hostname[:v1], impersonation
-                       [:v1], js-adapter[:v1], kerberos[:v1], linkedin-oauth[:v1], multi-site[:v1],
-                       offline-session-preloading[:v1], par[:v1], preview, recovery-codes[:v1],
-                       scripts[:v1], step-up-authentication[:v1], token-exchange[:v1],
-                       transient-users[:v1], update-email[:v1], web-authn[:v1].
+                       client-secret-rotation[:v1], client-types[:v1], declarative-ui[:v1],
+                       device-flow[:v1], docker[:v1], dpop[:v1], dynamic-scopes[:v1], fips[:v1],
+                       hostname[:v1], impersonation[:v1], js-adapter[:v1], kerberos[:v1],
+                       linkedin-oauth[:v1], multi-site[:v1], offline-session-preloading[:v1], par[:
+                       v1], preview, recovery-codes[:v1], scripts[:v1], step-up-authentication[:
+                       v1], token-exchange[:v1], transient-users[:v1], update-email[:v1], web-authn
+                       [:v1].
 --features-disabled <feature>
                      Disables a set of one or more features. Possible values are: account-api,
                        account2, account3, admin-api, admin-fine-grained-authz, admin2,
-                       authorization, ciba, client-policies, client-secret-rotation,
+                       authorization, ciba, client-policies, client-secret-rotation, client-types,
                        declarative-ui, device-flow, docker, dpop, dynamic-scopes, fips,
                        impersonation, js-adapter, kerberos, linkedin-oauth, multi-site,
                        offline-session-preloading, par, preview, recovery-codes, scripts,

diff --git a/...ak/it/cli/dist/approvals/cli/help/HelpCommandDistTest.testExportHelpAll.unix.approved.txt b/...ak/it/cli/dist/approvals/cli/help/HelpCommandDistTest.testExportHelpAll.unix.approved.txt
@@ -59,16 +59,17 @@ Feature:
 --features <feature> Enables a set of one or more features. Possible values are: account-api[:v1],
                        account2[:v1], account3[:v1], admin-api[:v1], admin-fine-grained-authz[:v1],
                        admin2[:v1], authorization[:v1], ciba[:v1], client-policies[:v1],
-                       client-secret-rotation[:v1], declarative-ui[:v1], device-flow[:v1], docker[:
-                       v1], dpop[:v1], dynamic-scopes[:v1], fips[:v1], hostname[:v1], impersonation
-                       [:v1], js-adapter[:v1], kerberos[:v1], linkedin-oauth[:v1], multi-site[:v1],
-                       offline-session-preloading[:v1], par[:v1], preview, recovery-codes[:v1],
-                       scripts[:v1], step-up-authentication[:v1], token-exchange[:v1],
-                       transient-users[:v1], update-email[:v1], web-authn[:v1].
+                       client-secret-rotation[:v1], client-types[:v1], declarative-ui[:v1],
+                       device-flow[:v1], docker[:v1], dpop[:v1], dynamic-scopes[:v1], fips[:v1],
+                       hostname[:v1], impersonation[:v1], js-adapter[:v1], kerberos[:v1],
+                       linkedin-oauth[:v1], multi-site[:v1], offline-session-preloading[:v1], par[:
+                       v1], preview, recovery-codes[:v1], scripts[:v1], step-up-authentication[:
+                       v1], token-exchange[:v1], transient-users[:v1], update-email[:v1], web-authn
+                       [:v1].
 --features-disabled <feature>
                      Disables a set of one or more features. Possible values are: account-api,
                        account2, account3, admin-api, admin-fine-grained-authz, admin2,
-                       authorization, ciba, client-policies, client-secret-rotation,
+                       authorization, ciba, client-policies, client-secret-rotation, client-types,
                        declarative-ui, device-flow, docker, dpop, dynamic-scopes, fips,
                        impersonation, js-adapter, kerberos, linkedin-oauth, multi-site,
                        offline-session-preloading, par, preview, recovery-codes, scripts,

diff --git a/...cloak/it/cli/dist/approvals/cli/help/HelpCommandDistTest.testImportHelp.unix.approved.txt b/...cloak/it/cli/dist/approvals/cli/help/HelpCommandDistTest.testImportHelp.unix.approved.txt
@@ -59,16 +59,17 @@ Feature:
 --features <feature> Enables a set of one or more features. Possible values are: account-api[:v1],
                        account2[:v1], account3[:v1], admin-api[:v1], admin-fine-grained-authz[:v1],
                        admin2[:v1], authorization[:v1], ciba[:v1], client-policies[:v1],
-                       client-secret-rotation[:v1], declarative-ui[:v1], device-flow[:v1], docker[:
-                       v1], dpop[:v1], dynamic-scopes[:v1], fips[:v1], hostname[:v1], impersonation
-                       [:v1], js-adapter[:v1], kerberos[:v1], linkedin-oauth[:v1], multi-site[:v1],
-                       offline-session-preloading[:v1], par[:v1], preview, recovery-codes[:v1],
-                       scripts[:v1], step-up-authentication[:v1], token-exchange[:v1],
-                       transient-users[:v1], update-email[:v1], web-authn[:v1].
+                       client-secret-rotation[:v1], client-types[:v1], declarative-ui[:v1],
+                       device-flow[:v1], docker[:v1], dpop[:v1], dynamic-scopes[:v1], fips[:v1],
+                       hostname[:v1], impersonation[:v1], js-adapter[:v1], kerberos[:v1],
+                       linkedin-oauth[:v1], multi-site[:v1], offline-session-preloading[:v1], par[:
+                       v1], preview, recovery-codes[:v1], scripts[:v1], step-up-authentication[:
+                       v1], token-exchange[:v1], transient-users[:v1], update-email[:v1], web-authn
+                       [:v1].
 --features-disabled <feature>
                      Disables a set of one or more features. Possible values are: account-api,
                        account2, account3, admin-api, admin-fine-grained-authz, admin2,
-                       authorization, ciba, client-policies, client-secret-rotation,
+                       authorization, ciba, client-policies, client-secret-rotation, client-types,
                        declarative-ui, device-flow, docker, dpop, dynamic-scopes, fips,
                        impersonation, js-adapter, kerberos, linkedin-oauth, multi-site,
                        offline-session-preloading, par, preview, recovery-codes, scripts,

diff --git a/...ak/it/cli/dist/approvals/cli/help/HelpCommandDistTest.testImportHelpAll.unix.approved.txt b/...ak/it/cli/dist/approvals/cli/help/HelpCommandDistTest.testImportHelpAll.unix.approved.txt
@@ -59,16 +59,17 @@ Feature:
 --features <feature> Enables a set of one or more features. Possible values are: account-api[:v1],
                        account2[:v1], account3[:v1], admin-api[:v1], admin-fine-grained-authz[:v1],
                        admin2[:v1], authorization[:v1], ciba[:v1], client-policies[:v1],
-                       client-secret-rotation[:v1], declarative-ui[:v1], device-flow[:v1], docker[:
-                       v1], dpop[:v1], dynamic-scopes[:v1], fips[:v1], hostname[:v1], impersonation
-                       [:v1], js-adapter[:v1], kerberos[:v1], linkedin-oauth[:v1], multi-site[:v1],
-                       offline-session-preloading[:v1], par[:v1], preview, recovery-codes[:v1],
-                       scripts[:v1], step-up-authentication[:v1], token-exchange[:v1],
-                       transient-users[:v1], update-email[:v1], web-authn[:v1].
+                       client-secret-rotation[:v1], client-types[:v1], declarative-ui[:v1],
+                       device-flow[:v1], docker[:v1], dpop[:v1], dynamic-scopes[:v1], fips[:v1],
+                       hostname[:v1], impersonation[:v1], js-adapter[:v1], kerberos[:v1],
+                       linkedin-oauth[:v1], multi-site[:v1], offline-session-preloading[:v1], par[:
+                       v1], preview, recovery-codes[:v1], scripts[:v1], step-up-authentication[:
+                       v1], token-exchange[:v1], transient-users[:v1], update-email[:v1], web-authn
+                       [:v1].
 --features-disabled <feature>
                      Disables a set of one or more features. Possible values are: account-api,
                        account2, account3, admin-api, admin-fine-grained-authz, admin2,
-                       authorization, ciba, client-policies, client-secret-rotation,
+                       authorization, ciba, client-policies, client-secret-rotation, client-types,
                        declarative-ui, device-flow, docker, dpop, dynamic-scopes, fips,
                        impersonation, js-adapter, kerberos, linkedin-oauth, multi-site,
                        offline-session-preloading, par, preview, recovery-codes, scripts,

diff --git a/...oak/it/cli/dist/approvals/cli/help/HelpCommandDistTest.testStartDevHelp.unix.approved.txt b/...oak/it/cli/dist/approvals/cli/help/HelpCommandDistTest.testStartDevHelp.unix.approved.txt
@@ -89,16 +89,17 @@ Feature:
 --features <feature> Enables a set of one or more features. Possible values are: account-api[:v1],
                        account2[:v1], account3[:v1], admin-api[:v1], admin-fine-grained-authz[:v1],
                        admin2[:v1], authorization[:v1], ciba[:v1], client-policies[:v1],
-                       client-secret-rotation[:v1], declarative-ui[:v1], device-flow[:v1], docker[:
-                       v1], dpop[:v1], dynamic-scopes[:v1], fips[:v1], hostname[:v1], impersonation
-                       [:v1], js-adapter[:v1], kerberos[:v1], linkedin-oauth[:v1], multi-site[:v1],
-                       offline-session-preloading[:v1], par[:v1], preview, recovery-codes[:v1],
-                       scripts[:v1], step-up-authentication[:v1], token-exchange[:v1],
-                       transient-users[:v1], update-email[:v1], web-authn[:v1].
+                       client-secret-rotation[:v1], client-types[:v1], declarative-ui[:v1],
+                       device-flow[:v1], docker[:v1], dpop[:v1], dynamic-scopes[:v1], fips[:v1],
+                       hostname[:v1], impersonation[:v1], js-adapter[:v1], kerberos[:v1],
+                       linkedin-oauth[:v1], multi-site[:v1], offline-session-preloading[:v1], par[:
+                       v1], preview, recovery-codes[:v1], scripts[:v1], step-up-authentication[:
+                       v1], token-exchange[:v1], transient-users[:v1], update-email[:v1], web-authn
+                       [:v1].
 --features-disabled <feature>
                      Disables a set of one or more features. Possible values are: account-api,
                        account2, account3, admin-api, admin-fine-grained-authz, admin2,
-                       authorization, ciba, client-policies, client-secret-rotation,
+                       authorization, ciba, client-policies, client-secret-rotation, client-types,
                        declarative-ui, device-flow, docker, dpop, dynamic-scopes, fips,
                        impersonation, js-adapter, kerberos, linkedin-oauth, multi-site,
                        offline-session-preloading, par, preview, recovery-codes, scripts,

diff --git a/.../it/cli/dist/approvals/cli/help/HelpCommandDistTest.testStartDevHelp.windows.approved.txt b/.../it/cli/dist/approvals/cli/help/HelpCommandDistTest.testStartDevHelp.windows.approved.txt
@@ -89,16 +89,17 @@ Feature:
 --features <feature> Enables a set of one or more features. Possible values are: account-api[:v1],
                        account2[:v1], account3[:v1], admin-api[:v1], admin-fine-grained-authz[:v1],
                        admin2[:v1], authorization[:v1], ciba[:v1], client-policies[:v1],
-                       client-secret-rotation[:v1], declarative-ui[:v1], device-flow[:v1], docker[:
-                       v1], dpop[:v1], dynamic-scopes[:v1], fips[:v1], hostname[:v1], impersonation
-                       [:v1], js-adapter[:v1], kerberos[:v1], linkedin-oauth[:v1], multi-site[:v1],
-                       offline-session-preloading[:v1], par[:v1], preview, recovery-codes[:v1],
-                       scripts[:v1], step-up-authentication[:v1], token-exchange[:v1],
-                       transient-users[:v1], update-email[:v1], web-authn[:v1].
+                       client-secret-rotation[:v1], client-types[:v1], declarative-ui[:v1],
+                       device-flow[:v1], docker[:v1], dpop[:v1], dynamic-scopes[:v1], fips[:v1],
+                       hostname[:v1], impersonation[:v1], js-adapter[:v1], kerberos[:v1],
+                       linkedin-oauth[:v1], multi-site[:v1], offline-session-preloading[:v1], par[:
+                       v1], preview, recovery-codes[:v1], scripts[:v1], step-up-authentication[:
+                       v1], token-exchange[:v1], transient-users[:v1], update-email[:v1], web-authn
+                       [:v1].
 --features-disabled <feature>
                      Disables a set of one or more features. Possible values are: account-api,
                        account2, account3, admin-api, admin-fine-grained-authz, admin2,
-                       authorization, ciba, client-policies, client-secret-rotation,
+                       authorization, ciba, client-policies, client-secret-rotation, client-types,
                        declarative-ui, device-flow, docker, dpop, dynamic-scopes, fips,
                        impersonation, js-adapter, kerberos, linkedin-oauth, multi-site,
                        offline-session-preloading, par, preview, recovery-codes, scripts,