Fixed resource and permission names and tooltip message (keycloak#26385)

* fixed typo Signed-off-by: Agnieszka Gancarczyk <[email protected]> * renamed key Signed-off-by: Agnieszka Gancarczyk <[email protected]> --------- Signed-off-by: Agnieszka Gancarczyk <[email protected]> Co-authored-by: Agnieszka Gancarczyk <[email protected]>
tnorimat · Jan 22, 2024 · 37e0f8f · 37e0f8f
1 parent 4a49759
commit 37e0f8f
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 4 deletions.
diff --git a/js/apps/admin-ui/maven-resources/theme/keycloak.v2/admin/messages/messages_en.properties b/js/apps/admin-ui/maven-resources/theme/keycloak.v2/admin/messages/messages_en.properties
@@ -3033,12 +3033,13 @@ selectEvictionMinute=Select eviction minute
 selectEditMode=Select edit mode
 emptySelection=Empty selection
 readOnlySelection=Read only selection
-writtableSelection=Writable selection
+writableSelection=Writable selection
 unsyncedSelection=Unsynced selection
 selectMapperType=Select mapper type
 editBtn=Edit button
 acceptBtn=Accept editing button
 cancelBtn=Cancel editing button
 chooseBindingType=Choose binding type
 selectFlowType=Select flow type
-selectClientAssertionSigningAlg=Select client assertion signing algorithm
+selectClientAssertionSigningAlg=Select client assertion signing algorithm
+resourceDetailsTypeHelp=The type of this resource. It can be used to group different resource instances with the same type.
diff --git a/js/apps/admin-ui/src/clients/authorization/PermissionDetails.tsx b/js/apps/admin-ui/src/clients/authorization/PermissionDetails.tsx
@@ -129,6 +129,7 @@ export default function PermissionDetails() {
           { id, type: permissionType },
           permission,
         );
+        setPermission(result);
         navigate(
           toPermissionDetails({
             realm,

diff --git a/js/apps/admin-ui/src/clients/authorization/ResourceDetails.tsx b/js/apps/admin-ui/src/clients/authorization/ResourceDetails.tsx
@@ -114,6 +114,7 @@ export default function ResourceDetails() {
           { id },
           resource,
         );
+        setResource(resource);
         navigate(toResourceDetails({ realm, id, resourceId: result._id! }));
       }
       addAlert(
@@ -250,7 +251,10 @@ export default function ResourceDetails() {
               label={t("type")}
               fieldId="type"
               labelIcon={
-                <HelpItem helpText={t("clientTypeHelp")} fieldLabelId="type" />
+                <HelpItem
+                  helpText={t("resourceDetailsTypeHelp")}
+                  fieldLabelId="type"
+                />
               }
             >
               <KeycloakTextInput id="type" {...register("type")} />

diff --git a/js/apps/admin-ui/src/identity-providers/add/DiscoverySettings.tsx b/js/apps/admin-ui/src/identity-providers/add/DiscoverySettings.tsx
@@ -134,6 +134,7 @@ const Fields = ({ readOnly }: DiscoverySettingsProps) => {
               <FormGroupField label="validatingPublicKey">
                 <KeycloakTextArea
                   data-testid="validatingPublicKey"
+                  aria-label={t("validatingPublicKey")}
                   {...register("config.publicKeySignatureVerifier")}
                 />
               </FormGroupField>

diff --git a/js/apps/admin-ui/src/user-federation/ldap/LdapSettingsSearching.tsx b/js/apps/admin-ui/src/user-federation/ldap/LdapSettingsSearching.tsx
@@ -100,7 +100,7 @@ export const LdapSettingsSearching = ({
                   value="READ_ONLY"
                 />
                 <SelectOption
-                  aria-label={t("writtableSelection")}
+                  aria-label={t("writableSelection")}
                   value="WRITABLE"
                 />
                 <SelectOption