Skip to content

openclaw: add approval source message links#5940

Open
patosullivan wants to merge 1 commit into
po/migrate-a2ui-pending-approvalsfrom
po/migrate-a2ui-source-nav
Open

openclaw: add approval source message links#5940
patosullivan wants to merge 1 commit into
po/migrate-a2ui-pending-approvalsfrom
po/migrate-a2ui-source-nav

Conversation

@patosullivan

Copy link
Copy Markdown
Member

Summary

Adds source-message navigation links to approval cards so the owner can jump to the originating message, plus a small a2ui component helper module (src/urbit/a2ui.ts).

Stacking / migration

Test plan

  • pnpm tsc --noEmit clean
  • Unit tests: 648/648 passing
  • Manifest in sync
  • Cherry-pick validated in openclaw-tlon (tsc + 571 tests) before relocation

Adds source-message navigation links to approval cards so the owner can jump to
the originating message, plus a small a2ui component helper module (urbit/a2ui.ts).

Migrated from tloncorp/openclaw-tlon#158 (authored by Dan Brewster). Cherry-picked
onto the rebased a2ui stack (#5939), relocated to packages/openclaw. blob.ts merged
cleanly with the context-lens/a2ui union from earlier in the stack.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bcce3dc8d3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

type: 'message' as const,
postId: messageId,
authorId: approval.requestingShip,
parentId: approval.originalMessage?.parentId,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Include parent authors for reply source links

When the approval came from a thread reply and the owner taps View message, the app's A2UI handler needs target.parentAuthorId if the parent post is not already in the local DB; otherwise it logs missing parent post author and returns before navigating (see packages/app/hooks/useA2UINavigation.ts:80-90). This target only carries parentId, so reply-source approvals from restricted channels/DMs can render a button that does nothing in that common uncached-parent case.

Useful? React with 👍 / 👎.

@patosullivan patosullivan changed the title feat(a2ui): add approval source message links openclaw: add approval source message links Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants