Skip to content

limit large video uploads#5849

Merged
dnbrwstr merged 3 commits into
developfrom
db/large-video-uploads
May 18, 2026
Merged

limit large video uploads#5849
dnbrwstr merged 3 commits into
developfrom
db/large-video-uploads

Conversation

@dnbrwstr
Copy link
Copy Markdown
Contributor

@dnbrwstr dnbrwstr commented May 15, 2026

Summary

Add a 150 MB video limit and apply it across the in-app picker, share intents, and the iOS share extension. This also tightens video detection for sparse media picker assets, surfaces attach failures to the user, and keeps share-extension uploads from failing just because thumbnail generation fails.

Fixes TLON-5793

Changes

  • Add shared video validation copy for too-large, unreadable, and unsupported videos
  • Treat sparse media picker video assets as videos before validating them
  • Show share intent attach errors in the channel UI
  • Stop the iOS share extension from copying oversized videos and keep sharing usable when thumbnail generation fails
  • Regenerate the expo-share-intent patch so clean native generation keeps the ShareViewController changes

How did I test?

Tested on device

@linear
Copy link
Copy Markdown

linear Bot commented May 15, 2026

TLON-5793

@dnbrwstr dnbrwstr force-pushed the db/large-video-uploads branch from 67b2736 to 7d2ce3a Compare May 15, 2026 18:13
@dnbrwstr dnbrwstr marked this pull request as ready for review May 18, 2026 15:29
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Large diff in this fie is because it wasn't regenerated after the update to 5.1.1. This should have no effect in practice -- it just gets us to a generated ShareViewController which matches the one we've actually been using.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7d2ce3a982

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/app/utils/filepicker.ts Outdated
Copy link
Copy Markdown
Member

@patosullivan patosullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link
Copy Markdown
Member

@arthyn arthyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to limit for share extension and memex, but I really think we shouldn't limit uploads where we can, like in web generally or in file picker on mobile. we should probably let self-hosters upload w/e size up to the S3 single request cap ~5gb.

@dnbrwstr
Copy link
Copy Markdown
Contributor Author

makes sense to limit for share extension and memex, but I really think we shouldn't limit uploads where we can, like in web generally or in file picker on mobile. we should probably let self-hosters upload w/e size up to the S3 single request cap ~5gb.

I removed the limitation on web. Agree it would be nicer not to cap, but on mobile right now the experience is not great + pretty prone to failure.

@dnbrwstr dnbrwstr merged commit 96ac2bb into develop May 18, 2026
4 checks passed
@dnbrwstr dnbrwstr deleted the db/large-video-uploads branch May 18, 2026 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants