limit large video uploads#5849
Conversation
67b2736 to
7d2ce3a
Compare
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
There was a problem hiding this comment.
Large diff in this fie is because it wasn't regenerated after the update to 5.1.1. This should have no effect in practice -- it just gets us to a generated ShareViewController which matches the one we've actually been using.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7d2ce3a982
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
arthyn
left a comment
There was a problem hiding this comment.
makes sense to limit for share extension and memex, but I really think we shouldn't limit uploads where we can, like in web generally or in file picker on mobile. we should probably let self-hosters upload w/e size up to the S3 single request cap ~5gb.
I removed the limitation on web. Agree it would be nicer not to cap, but on mobile right now the experience is not great + pretty prone to failure. |
Summary
Add a 150 MB video limit and apply it across the in-app picker, share intents, and the iOS share extension. This also tightens video detection for sparse media picker assets, surfaces attach failures to the user, and keeps share-extension uploads from failing just because thumbnail generation fails.
Fixes TLON-5793
Changes
How did I test?
Tested on device