devex: route script-shell via TLON_SHELL so windows can use git bash#5848
Open
jamesacklin wants to merge 2 commits into
Open
devex: route script-shell via TLON_SHELL so windows can use git bash#5848jamesacklin wants to merge 2 commits into
jamesacklin wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Several package.json scripts use Unix shell tools (
rm -rf,cp -R,mkdir -p) that fail on Windows' defaultcmd.exe. Pointing pnpm's script-shell at${TLON_SHELL-/bin/bash}lets Windows contributors setTLON_SHELLto Git Bash without rewriting any existing scripts; Unix users keep/bin/bashautomatically via the default-value expansion. Documents the Windows setup inCLAUDE.md, including the WSL-bash trap onPATHand the Node 22 pin needed for prebuiltbetter-sqlite3binaries.Changes
How did I test?
Risks and impact
Rollback plan
git revert
Screenshots