Skip to content

devex: route script-shell via TLON_SHELL so windows can use git bash#5848

Open
jamesacklin wants to merge 2 commits into
developfrom
jamesacklin/windows-dev-compat
Open

devex: route script-shell via TLON_SHELL so windows can use git bash#5848
jamesacklin wants to merge 2 commits into
developfrom
jamesacklin/windows-dev-compat

Conversation

@jamesacklin
Copy link
Copy Markdown
Member

@jamesacklin jamesacklin commented May 14, 2026

Summary

Several package.json scripts use Unix shell tools (rm -rf, cp -R, mkdir -p) that fail on Windows' default cmd.exe. Pointing pnpm's script-shell at ${TLON_SHELL-/bin/bash} lets Windows contributors set TLON_SHELL to Git Bash without rewriting any existing scripts; Unix users keep /bin/bash automatically via the default-value expansion. Documents the Windows setup in CLAUDE.md, including the WSL-bash trap on PATH and the Node 22 pin needed for prebuilt better-sqlite3 binaries.

Changes

  • Tells pnpm to run all package.json scripts through whatever $TLON_SHELL points to, falling back to /bin/bash when the env var is unset
  • Updates CLAUDE.md to tell the robots what to do when initializing on Windows

How did I test?

Risks and impact

  • Safe to rollback without consulting PR author? Yes
  • Affects important code area:
    • Onboarding
    • State / providers
    • Message sync
    • Channel display
    • Notifications
    • Other: dev environment

Rollback plan

git revert

Screenshots

image

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@jamesacklin jamesacklin requested a review from dnbrwstr May 14, 2026 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant