[codex] Add browser notifications#5846
Draft
wca4a wants to merge 1 commit into
Draft
Conversation
Member
|
Will want to target |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds true browser Notification API support for Tlon web while the tab is open or backgrounded.
%activityupdates and emits native browser notifications forshouldNotifyactivity eventsmastersettings UINotes
This does not implement closed-tab Web Push. That would require service worker
pushhandling plus PushManager/VAPID/provider support.The remote does not have a branch named
stable, so this branch is based onorigin/master, which appears to be the stable/release branch.Validation
git diff --checkpassedmaster:pnpm --filter 'tlon-web' tscpassed andpnpm --filter 'tlon-web' buildpassedorigin/master,pnpm --filter 'tlon-web' tsc --pretty falseis blocked by existing stable-branch/local dependency issues unrelated to this patch, including@urbit/auraexport mismatches and missing native/web dependency typingsmasterdependencies withpnpm install --frozen-lockfile --force,pnpm --filter 'tlon-web' buildstarts and transforms the app but is blocked by an existingexpo-audioweb export mismatch (PLAYBACK_STATUS_UPDATEis not exported byExpoAudio.web.js)Manual Test
Verified locally against
https://malmur-halmex.tlon.networkthrough the web dev server. Browser permission state appears under Settings -> Notification settings -> Browser notifications, and blocked origins reportBlocked in browser.