Add slash command menu#5813
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
@claude review once |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 83285d1471
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| (cursorPosition === lastSlashIndex + 1 || | ||
| (cursorPosition > lastSlashIndex && !afterCursor.includes(' '))) | ||
| ) { |
There was a problem hiding this comment.
Treat all whitespace as slash-command terminator
The slash parser only checks afterCursor.includes(' '), so it ignores other whitespace like \n or tabs. In a multiline draft such as /st\nnext, placing the caret before the newline keeps slash mode active because afterCursor has no literal space, which can reopen the popup and route Enter to command selection instead of normal send/edit behavior. This should use a whitespace check (e.g. /\s/) consistent with the rest of the parser.
Useful? React with 👍 / 👎.
|
What does this look like on a mobile device? |
|
Let's do something about those extra-long helper strings but otherwise looks OK to me. |

Summary
Tests