marks: patch up#5764
Conversation
Many marks didn't compile into proper mark cores. Here, we make a bunch of changes to correct this.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5f0279b8a8
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| |% | ||
| ++ noun create:v7:gv | ||
| ++ json create:v7:dejs:j | ||
| ++ json |=(^json *create:v7:gv) ::TODO REVIEW create:v7:dejs:j doesn't exist |
There was a problem hiding this comment.
grab now defines ++ json as |=(^json *create:v7:gv) which ignores the incoming JSON payload and always returns the bunt/default create:v7:gv value. In any path that decodes %group-create JSON through this mark, user-supplied fields (name, metadata, members, etc.) are dropped, so downstream logic receives incorrect data and can create the wrong group state or fail validation unexpectedly.
Useful? React with 👍 / 👎.
This comment has been minimized.
This comment has been minimized.
|
The e2e test fail here seems to be a client bug, but since we touch a whole bunch of marks let's wait until that gets fixed and merge develop to have a clean pass. |
This was pre-channels agent!
2 participants
Summary
Many marks didn't compile into proper mark cores. Here, we make a bunch of changes to correct this.
These changes are necessary for #5668 to be able to incorporate all marks properly.
Changes
Mostly straightforward changes: making sure we're in type parsing mode, specifying a
+grad, making sure we can+noun:grab, etc.Special review attention request for the following:
/mar/chat/writs.hoonand/mar/group/invites.hoonpull in the right type versions?/mar/group/create.hoon? The json conversion util it tried using doesn't seem to exist at all.../mar/writ-diff.hoonaka%writ-diffseems to be completely unused. I think it's a very old mark. Should we just remove it?How did I test?
Compiled all the marks for #5668.
Risks and impact
Rollback plan
Revert.