sync: account for reply tombstones#5343
Merged
Merged
Conversation
patosullivan
approved these changes
Dec 5, 2025
Member
patosullivan
left a comment
There was a problem hiding this comment.
One question, otherwise LGTM
Member
|
Please target release/803, I'll open another PR to merge back into develop. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reply parsing was throwing in cases where a thread message was deleted: this results in a tombstone, but wasn't accounted for in method type signatures.
While investigating, I discovered that reply deletes don't work at all. We weren't accounting for the different format and the action sheet fires a generic post delete when you try from a thread. The optimistic update would stick however, so it was deceptive.
Another issue that cropped up while working on it: we had a lingering bug from the @aura upgrade. #5342 should resolve this, but we'll need that to land first. That'll block functional review, but be otherwise fine for code review.
Changes
apimethod for handling reply deletesdeletePostinactionmoduleurbitmoduleHow did I test?
I deleted messages after fixing the API. Confirmed this creates the parse error that we saw breaking sync. Confirmed with the fix, we get no such parse error.
TODO: this is working for group channels, but I'm seeing a type issue with DMs
Risks and impact
Operational Note
I think we should merge this into develop and then cherrypick onto the
8.0.3hotfix branchFixes TLON-5128