api: when parsing @ud, also accept plain decimal

packages/shared/src/api/apiUtils.ts

@@ -1,6 +1,7 @@
 import {
   render,
   parse,
+  tryParse,
   da
 } from '@urbit/aura';
 import bigInt from 'big-integer';
@@ -60,7 +61,18 @@ export function formatUd(ud: string) {  //REVIEW
 }
 
 export function udToDate(das: string) {
-  return da.toUnix(parse('ud', das));
+  return da.toUnix(parseIdNumber(das));
+}
+
+//  parses either a @ud-formatted string (dot-separated decimal) or a plain
+//  decimal number string (aka @ui without the prefix).
+//  we try both instead of being precise at the callsites, because historically
+//  we used a too-lenient @ud parser, which also accepted dotless
+//  representations, making it slightly unclear/ambiguous what we were actually
+//  *intending* to parse. the backend is wildly inconsistent, so this is easier
+//  and safer than figuring all that out. (we'll tighten things up Soon™.)
+export function parseIdNumber(id: string): bigint {
+  return tryParse('ud', id) || BigInt(id);
 }
 
 export function formatDateParam(date: Date) {

packages/shared/src/logic/references.ts

@@ -1,10 +1,9 @@
-import { parse } from '@urbit/aura';
-
 import * as db from '../db';
 import { ContentReference } from '../domain';
+import { parseIdNumber } from '../api/apiUtils';
 
 function formatId(id: string) {
-  return parse('ud', id).toString();
+  return parseIdNumber(id).toString();
 }
 
 export function getPostReferencePath(post: db.Post) {

packages/shared/src/urbit/activity.ts

@@ -1,10 +1,11 @@
-import { parse, da } from '@urbit/aura';
+import { da } from '@urbit/aura';
 import _ from 'lodash';
 
 import type { UnionToIntersection } from '../utils';
 import { Kind, Story } from './channel';
 import { ContactBookProfile } from './contact';
 import { nestToFlag, whomIsDm, whomIsFlag, whomIsMultiDm } from './utils';
+import { parseIdNumber } from '../api/apiUtils';
 
 export type Whom = { ship: string } | { club: string };
 
@@ -773,7 +774,7 @@ export function getIdParts(id: string): { author: string; sent: number } {
   const [author, sentStr] = id.split('/');
   return {
     author,
-    sent: da.toUnix(parse('ud', sentStr)),
+    sent: da.toUnix(parseIdNumber(sentStr)),
   };
 }
 

packages/shared/src/urbit/channel.ts

@@ -1,4 +1,3 @@
-import { parse } from '@urbit/aura';
 import bigInt, { BigInteger } from 'big-integer';  //REVIEW  non-native!
 import _ from 'lodash';
 import BTree from 'sorted-btree';
@@ -7,6 +6,7 @@ import { Stringified } from '../utils';
 import { Block, Image, Inline, isBlock, isImage } from './content';
 import { Flag } from './hark';
 import { Metadata } from './meta';
+import { parseIdNumber } from '../api/apiUtils';
 
 export interface CacheId {
   author: string;
@@ -615,7 +615,7 @@ export function newPostTupleArray(
     data.pages
       .map((page) => {
         const pagePosts = Object.entries(page.posts).map(
-          ([k, v]) => [bigInt(parse('ud', k)), v] as PostTuple
+          ([k, v]) => [bigInt(parseIdNumber(k)), v] as PostTuple
         );
 
         return pagePosts;

packages/shared/src/urbit/dms.ts

@@ -1,4 +1,3 @@
-import { parse } from '@urbit/aura';
 import bigInt, { BigInteger } from 'big-integer';  //REVIEW  non-native!
 import _ from 'lodash';
 import BTree from 'sorted-btree';
@@ -13,6 +12,7 @@ import {
   ReplySeal,
 } from './channel';
 import { GroupMeta } from './groups';
+import { parseIdNumber } from '../api/apiUtils';
 
 export type Patda = string;
 export type Ship = string;
@@ -206,7 +206,7 @@ export function newWritTupleArray(
     data?.pages
       ?.map((page) => {
         const writPages = Object.entries(page.writs).map(
-          ([k, v]) => [bigInt(parse('ud', k)), v] as WritTuple
+          ([k, v]) => [bigInt(parseIdNumber(k)), v] as WritTuple
         );
         return writPages;
       })