Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus exporter for Layer 2 Lower MAC #11

Merged
merged 16 commits into from
Jun 6, 2024
Merged

Prometheus exporter for Layer 2 Lower MAC #11

merged 16 commits into from
Jun 6, 2024

Conversation

marenz2569
Copy link
Member

@marenz2569 marenz2569 commented Jun 2, 2024 •
edited
Loading

Things that this PR should implement:

  • counter for received bursts
  • counter for received bursts with/without lower mac decoding errors (crc16 ccitt)
  • counter for skipped bursts

@marenz2569 marenz2569 requested a review from tanneberger June 2, 2024 12:50
@marenz2569 marenz2569 changed the title WIP - Add prometheus exporter for Layer 2 Lower MAC WIP - Prometheus exporter for Layer 2 Lower MAC Jun 2, 2024
@marenz2569
Copy link
Member Author

marenz2569 commented Jun 2, 2024 •
edited
Loading

  • finish refactoring for the uplink w/o synchronization burst and given scrambling code

@marenz2569 marenz2569 self-assigned this Jun 3, 2024
@marenz2569 marenz2569 marked this pull request as ready for review June 3, 2024 23:50
@marenz2569 marenz2569 changed the title WIP - Prometheus exporter for Layer 2 Lower MAC Prometheus exporter for Layer 2 Lower MAC Jun 3, 2024
tanneberger
tanneberger approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@tanneberger tanneberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

marenz a lot of variable names a just horrible

include/l2/access_assignment_channel.hpp Show resolved Hide resolved
include/l2/broadcast_synchronization_channel.hpp Outdated Show resolved Hide resolved
src/l2/lower_mac.cpp Show resolved Hide resolved
@marenz2569 marenz2569 force-pushed the feature/prometheus-exporter branch from 9ef30aa to 6e1042f Compare June 6, 2024 19:41
@marenz2569 marenz2569 merged commit 4a43f93 into master Jun 6, 2024
2 checks passed
@marenz2569 marenz2569 deleted the feature/prometheus-exporter branch June 6, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanneberger tanneberger tanneberger approved these changes

Assignees

@marenz2569 marenz2569

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marenz2569 @tanneberger