Clarify MSRV for workspace lints

Cargo.toml

@@ -8,7 +8,12 @@ authors = ["Tancrède Lepoint"]
 edition = "2021"
 repository = "https://github.com/tlepoint/fhe.rs"
 license = "MIT"
-rust-version = "1.73"
+rust-version = "1.74" # MSRV for workspace lints
+
+[workspace.lints.rust]
+missing_docs = "warn"
+unused_imports = "warn"
+unused_must_use = "deny"
 
 [workspace.dependencies]
 clap = { version = "^4.5.53", features = ["derive"] }
@@ -37,6 +42,8 @@ zeroize = "^1.8.2"
 zeroize_derive = "^1.4.2"
 
 [workspace.lints.clippy]
+expect_used = "deny"
+panic = "deny"
 indexing_slicing = "deny"
 fallible_impl_from = "deny"
 wildcard_enum_match_arm = "deny"

README.md

@@ -34,7 +34,7 @@ fhe-traits = "0.1.1"
 
 ## Minimum supported version / toolchain
 
-Rust **1.73** or newer.
+Rust **1.74** or newer (required for workspace lint configuration).
 
 ## ⚠️ Security / Stability
 

crates/fhe-math/benches/ntt.rs

@@ -1,5 +1,6 @@
 // Allow indexing in benchmarks for convenience
 #![allow(clippy::indexing_slicing)]
+#![allow(missing_docs)]
 
 use criterion::{criterion_group, criterion_main, BenchmarkId, Criterion};
 use fhe_math::{ntt::NttOperator, zq::Modulus};

crates/fhe-math/benches/rns.rs

@@ -1,5 +1,6 @@
 // Allow indexing in benchmarks for convenience
 #![allow(clippy::indexing_slicing)]
+#![allow(missing_docs)]
 
 use criterion::{criterion_group, criterion_main, BenchmarkId, Criterion};
 use fhe_math::rns::{RnsContext, RnsScaler, ScalingFactor};

crates/fhe-math/benches/rq.rs

@@ -1,5 +1,6 @@
 // Allow indexing in benchmarks for convenience
 #![allow(clippy::indexing_slicing)]
+#![allow(missing_docs)]
 
 use criterion::measurement::WallTime;
 use criterion::{criterion_group, criterion_main, BenchmarkGroup, BenchmarkId, Criterion};

crates/fhe-math/benches/zq.rs

@@ -1,5 +1,6 @@
 // Allow indexing in benchmarks for convenience
 #![allow(clippy::indexing_slicing)]
+#![allow(missing_docs)]
 
 use criterion::{criterion_group, criterion_main, BenchmarkId, Criterion};
 use fhe_math::zq::Modulus;

crates/fhe-math/src/lib.rs

@@ -1,6 +1,5 @@
 #![crate_name = "fhe_math"]
 #![crate_type = "lib"]
-#![warn(missing_docs, unused_imports)]
 
 //! Mathematical utilities for the fhe.rs library.
 

crates/fhe-math/src/rq/convert.rs

@@ -434,6 +434,8 @@ impl From<&Poly> for Vec<BigUint> {
 
 #[cfg(test)]
 mod tests {
+    #![allow(clippy::expect_used)]
+
     use crate::{
         proto::rq::Rq,
         rq::{traits::TryConvertFrom, Context, Poly, Representation},

crates/fhe-math/src/rq/ops.rs

@@ -110,6 +110,7 @@ impl Sub<&Poly> for &Poly {
 }
 
 impl MulAssign<&Poly> for Poly {
+    #[allow(clippy::panic)]
     fn mul_assign(&mut self, p: &Poly) {
         assert!(!p.has_lazy_coefficients);
         assert_ne!(

crates/fhe-traits/src/lib.rs

@@ -1,6 +1,5 @@
 #![crate_name = "fhe_traits"]
 #![crate_type = "lib"]
-#![warn(missing_docs, unused_imports)]
 
 //! Traits for Fully Homomorphic Encryption
 

crates/fhe-util/src/lib.rs

@@ -1,6 +1,5 @@
 #![crate_name = "fhe_util"]
 #![crate_type = "lib"]
-#![warn(missing_docs, unused_imports)]
 
 //! Utilities for the fhe.rs library.
 
@@ -57,6 +56,7 @@ pub fn sample_vec_cbd<R: RngCore + CryptoRng>(
 
 /// Transcodes a vector of u64 of `nbits`-bit numbers into a vector of bytes.
 #[must_use]
+#[allow(clippy::expect_used)]
 pub fn transcode_to_bytes(a: &[u64], nbits: usize) -> Vec<u8> {
     assert!(0 < nbits && nbits <= 64);
 
@@ -96,6 +96,7 @@ pub fn transcode_to_bytes(a: &[u64], nbits: usize) -> Vec<u8> {
 
 /// Transcodes a vector of u8 into a vector of u64 of `nbits`-bit numbers.
 #[must_use]
+#[allow(clippy::expect_used)]
 pub fn transcode_from_bytes(b: &[u8], nbits: usize) -> Vec<u64> {
     assert!(0 < nbits && nbits <= 64);
     let mask = (u64::MAX >> (64 - nbits)) as u128;
@@ -134,6 +135,7 @@ pub fn transcode_from_bytes(b: &[u8], nbits: usize) -> Vec<u64> {
 /// Transcodes a vector of u64 of `input_nbits`-bit numbers into a vector of u64
 /// of `output_nbits`-bit numbers.
 #[must_use]
+#[allow(clippy::expect_used)]
 pub fn transcode_bidirectional(a: &[u64], input_nbits: usize, output_nbits: usize) -> Vec<u64> {
     assert!(0 < input_nbits && input_nbits <= 64);
     assert!(0 < output_nbits && output_nbits <= 64);
@@ -281,6 +283,14 @@ mod tests {
         }
     }
 
+    #[test]
+    fn transcode_known_roundtrip() {
+        let input = vec![0x1u64, 0x2u64, 0x3u64, 0x4u64];
+        let bytes = transcode_to_bytes(&input, 4);
+        let decoded = transcode_from_bytes(&bytes, 4);
+        assert_eq!(&decoded[..input.len()], input);
+    }
+
     #[test]
     fn inv_kats() {
         // KATs for inversion generated in Sage using the following code.

crates/fhe/benches/bfv.rs

@@ -1,5 +1,6 @@
 // Allow indexing in benchmarks for convenience
 #![allow(clippy::indexing_slicing)]
+#![allow(missing_docs)]
 
 use criterion::{criterion_group, criterion_main, BenchmarkId, Criterion};
 use fhe::bfv::{

crates/fhe/benches/bfv_optimized_ops.rs

@@ -1,5 +1,6 @@
 // Allow indexing in benchmarks for convenience
 #![allow(clippy::indexing_slicing)]
+#![allow(missing_docs)]
 
 use criterion::{criterion_group, criterion_main, BenchmarkId, Criterion};
 use fhe::bfv::{dot_product_scalar, BfvParameters, Ciphertext, Encoding, Plaintext, SecretKey};

crates/fhe/benches/bfv_rgsw.rs

@@ -1,5 +1,6 @@
 // Allow indexing in benchmarks for convenience
 #![allow(clippy::indexing_slicing)]
+#![allow(missing_docs)]
 
 use criterion::{criterion_group, criterion_main, BenchmarkId, Criterion};
 use fhe::bfv::{BfvParameters, Ciphertext, Encoding, Plaintext, RGSWCiphertext, SecretKey};

crates/fhe/examples/bfv_basic.rs

@@ -1,5 +1,6 @@
 // Allow indexing in examples for simplicity
 #![allow(clippy::indexing_slicing)]
+#![allow(missing_docs)]
 
 use std::error::Error;
 

crates/fhe/examples/bfv_ops.rs

@@ -1,5 +1,6 @@
 // Allow indexing in examples for simplicity
 #![allow(clippy::indexing_slicing)]
+#![allow(missing_docs)]
 
 mod util;
 

crates/fhe/examples/mulpir.rs

@@ -1,5 +1,6 @@
 // Allow indexing in examples for simplicity
 #![allow(clippy::indexing_slicing)]
+#![allow(missing_docs)]
 
 // Implementation of MulPIR using the `fhe` crate.
 //

crates/fhe/examples/pir.rs

@@ -1,5 +1,6 @@
 // Allow indexing in examples for simplicity
 #![allow(clippy::indexing_slicing)]
+#![allow(missing_docs)]
 
 use clap::Parser;
 

crates/fhe/examples/rgsw.rs

@@ -1,5 +1,6 @@
 // Allow indexing in examples for simplicity
 #![allow(clippy::indexing_slicing)]
+#![allow(missing_docs)]
 
 use std::error::Error;
 

crates/fhe/examples/sealpir.rs

@@ -1,5 +1,6 @@
 // Allow indexing in examples for simplicity
 #![allow(clippy::indexing_slicing)]
+#![allow(missing_docs)]
 
 // Implementation of SealPIR using the `fhe` crate.
 //

crates/fhe/examples/util.rs

@@ -1,5 +1,6 @@
 // Allow indexing in examples for simplicity
 #![allow(clippy::indexing_slicing)]
+#![allow(missing_docs)]
 
 //! Utility functions for the examples
 

crates/fhe/examples/voting.rs

@@ -1,5 +1,6 @@
 // Allow indexing in examples for simplicity
 #![allow(clippy::indexing_slicing)]
+#![allow(missing_docs)]
 
 // Implementation of multiparty voting using the `fhe` crate.
 

crates/fhe/src/bfv/ciphertext.rs

@@ -47,6 +47,7 @@ impl Ciphertext {
     /// Create a ciphertext from a vector of polynomials.
     /// A ciphertext must contain at least two polynomials, and all polynomials
     /// must be in Ntt representation and with the same context.
+    #[allow(clippy::expect_used)]
     pub fn new(c: Vec<Poly>, par: &Arc<BfvParameters>) -> Result<Self> {
         if c.len() < 2 {
             return Err(Error::TooFewValues {
@@ -358,6 +359,7 @@ mod tests {
     }
 
     #[test]
+    #[allow(clippy::panic)]
     fn switch_to_level_invalid() -> Result<(), Box<dyn StdError>> {
         let mut rng = rng();
         let params = BfvParameters::default_arc(2, 16);

crates/fhe/src/bfv/context/chain.rs

@@ -132,6 +132,7 @@ impl ContextLevel {
     }
 
     /// Access multiplication parameters for this level
+    #[allow(clippy::expect_used)]
     pub(crate) fn mul_params(&self) -> &MultiplicationParameters {
         self.mul_params
             .get()

crates/fhe/src/bfv/parameters.rs

@@ -246,6 +246,7 @@ impl BfvParameters {
     #[cfg(test)]
     /// Returns default parameters for tests.
     #[must_use]
+    #[allow(clippy::panic)]
     pub fn default_arc(num_moduli: usize, degree: usize) -> Arc<Self> {
         if !degree.is_power_of_two() || degree < 8 {
             panic!("Invalid degree");
@@ -691,6 +692,7 @@ mod tests {
         let result = BfvParameters::default_parameters_128(10);
         assert!(result.is_err());
 
+        #[allow(clippy::panic)]
         match result {
             Err(e) => {
                 let error_string = format!("{e}");

crates/fhe/src/lib.rs

@@ -1,6 +1,5 @@
 #![crate_name = "fhe"]
 #![crate_type = "lib"]
-#![warn(missing_docs, unused_imports)]
 #![doc = include_str!("../README.md")]
 
 mod errors;

crates/fhe/tests/unified_context_integration.rs

@@ -1,4 +1,6 @@
 // Integration test to verify the unified context management API works correctly
+#![allow(missing_docs)]
+
 use fhe::bfv::BfvParametersBuilder;
 
 #[test]