Refactor fhe math idiomatic rust#290
Merged
Merged
Conversation
This commit introduces several changes to the `fhe-math` crate to make the code more idiomatic, readable, and maintainable, without affecting performance. The following changes were made in `crates/fhe-math/src/rq/mod.rs`: - Removed redundant `AsRef<Poly>` and `AsMut<Poly>` implementations. The standard library provides blanket implementations for these traits. - Refactored `Poly::change_representation` to use a single `match` on a tuple of representations, which simplifies the control flow. - Simplified `Poly::substitute` by merging the `Ntt` and `NttShoup` match arms, reducing code duplication. - Refactored `Poly::mod_switch_down_next` to eliminate code duplication between constant-time and variable-time computation paths by using function pointers. - Improved error handling in `Poly::small` by using an early return for the invalid variance case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces several changes to the
fhe-mathcrate to make the code more idiomatic, readable, and maintainable, without affecting performance.The following changes were made in
crates/fhe-math/src/rq/mod.rs:Poly::change_representationto use a singlematchon a tuple of representations, which simplifies the control flow.Poly::substituteby merging theNttandNttShoupmatch arms, reducing code duplication.Poly::mod_switch_down_nextto eliminate code duplication between constant-time and variable-time computation paths by using function pointers.Poly::smallby using an early return for the invalid variance case.