docs: fix API method names from list* to get* #419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Keys, listSmartContractInterfaces, listUsers, listWallets, listWalletAccounts, whoami)from list* to get*
amircheikh
reviewed
Sep 18, 2025
| path, | ||
| method: method as HttpMethod, | ||
| description: operation.description || "", | ||
| // <-- New line to capture operationId from the OpenAPI spec |
There was a problem hiding this comment.
I think you can remove the "new line" part.
amircheikh
reviewed
Sep 18, 2025
| /** | ||
| * Operation ID from the OpenAPI spec (used for SDK method naming) | ||
| */ | ||
| operationId?: string; // <-- Added |
There was a problem hiding this comment.
Can remove this "Added" comment
amircheikh
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update API method names in the docs to match the actual method name.
Affected methods:
listActivities,listPolicies,listPrivateKeys,listSmartContractInterfaces,listUsers,listWallets,listWalletAccounts,whoamiReason:
The old names caused runtime errors like:
TypeError: turnkeyClient.apiClient(...).listActivities is not a function