-
Notifications
You must be signed in to change notification settings - Fork 4
Cmssw 10 x 2018 #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tjavaid
wants to merge
43
commits into
tjavaid:master
Choose a base branch
from
vukasinmilosevic:CMSSW_10_X_2018
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ram1123
referenced
this pull request
in ram1123/Fiducial_XS
Feb 17, 2022
tjavaid
pushed a commit
that referenced
this pull request
Aug 25, 2022
…ath, etc. (#11) * Addded .gitignore file and indentation update done automatically by my editor * update * cleaned: Started by deleting everying then added each file one by one depending on error message * Updating as per Tahir PR vukasinmilosevic#1 * Created a model directory and added HZZ model into that * Fix the bug introduced from optparser in efficiencyFactor.py * Updated all main changes from Tahir main PR vukasinmilosevic#1 * Restructured directory * Update * Update * Fix the two changes as discussed: 1. Name change of the directory for combine output: `combineLogs` -> `combineOutputs` 2. Uncomment the commented part that I did by mistake * - Bug fix - Update print statements * Redirected all outputs to the directory xs_125.0 * Update * Minor print changes and added docstring for few functions * - Make uniform convention for directory for combine related .root files - In earlier versin it was mixed up between `xs_125.0` and `combineOutputs` - Now, all the hardcoded instance of xs_125.0 is removed and instead used a variable named `combineOutputs` and this variable store `xs_125.0` in every file whereever its required. * moved the from RunEverything.py to efficiencyFactors.py * Removed all hardcoded instances of directory `datacardInputs` instead added variable `datacardInputs`. * Removed the doLScan_mass4l.sh instead added all 8 commands inside runHZZFiducialXS.py. Don't think we have some benefiting in keeping doLScan_mass4l.sh * Defined a file and added output directories name here. And linked this to all relevant files * Understanding efficiency factors (#1) * - BugFix: Angular variables (i.e. phi, phi1, etc) was giving error as reported in vukasinmilosevic#17 - Exported obsList.py to ObsList.yml * Update the modules load method - Earlier I was adding (using sys.path.insert()) the paths where modules where present - Now, I added a `setup.sh` script to put these path where modules are present to the PYTHONPATH - Using this I won't have to bother about the exact location where these modules are present and load in each macro with respect to the relative path - Earlier, if I change the name of main directory from "Fiducial_XS" to somethine else then few macros won't able to load. * Don't remove the executable main_fiducialXSTemplates everytime; it will be updated if we updated the main_fiducialXSTemplates.cpp using make command * Now, plot2dsigeffs.py is importing label name from YAML file * Added unit in the observabel YAML file, its used in the plotDifferentialBins.py; Now, removed many unit related line from plotDifferentialBins.py, as its taken from YAML file now * - moved back the ROOT import where it was earlier because of optparser and ROOT options interface. - Reference: https://root-forum.cern.ch/t/python-options-and-root-options/4641/3 * removed __main__ from efficiencyFactors.py * Added GEN into in observables_list.yml file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.