Skip to content

Conversation

@tjavaid
Copy link
Owner

@tjavaid tjavaid commented Jan 13, 2022

No description provided.

ram1123 referenced this pull request in ram1123/Fiducial_XS Feb 17, 2022
tjavaid pushed a commit that referenced this pull request Aug 25, 2022
…ath, etc. (#11)

* Addded .gitignore file and indentation update done automatically by my editor

* update

* cleaned: Started by deleting everying then added each file one by one depending on error message

* Updating as per Tahir PR vukasinmilosevic#1

* Created a model directory and added HZZ model into that

* Fix the bug introduced from optparser in efficiencyFactor.py

* Updated all main changes from Tahir main PR vukasinmilosevic#1

* Restructured directory

* Update

* Update

* Fix the two changes as discussed:

1. Name change of the directory for combine output: `combineLogs` -> `combineOutputs`
2. Uncomment the commented part that I did by mistake

* - Bug fix
- Update print statements

* Redirected all outputs to the directory xs_125.0

* Update

* Minor print changes and added docstring for few functions

* - Make uniform convention for directory for combine related .root files
- In earlier versin it was mixed up between `xs_125.0` and `combineOutputs`
- Now, all the hardcoded instance of xs_125.0 is removed and instead used a variable named `combineOutputs` and this variable store `xs_125.0` in every file whereever its required.

* moved the  from RunEverything.py to efficiencyFactors.py

* Removed all hardcoded instances of directory `datacardInputs` instead added variable `datacardInputs`.

* Removed the doLScan_mass4l.sh instead added all 8 commands inside runHZZFiducialXS.py. Don't think we have some benefiting in keeping doLScan_mass4l.sh

* Defined a file  and added output directories name here. And linked this to all relevant files

* Understanding efficiency factors (#1)

* - BugFix: Angular variables (i.e. phi, phi1, etc) was giving error as reported in vukasinmilosevic#17
- Exported obsList.py to ObsList.yml

* Update the modules load method

- Earlier I was adding (using sys.path.insert()) the paths where modules where present
- Now, I added a `setup.sh` script to put these path where modules are present to the PYTHONPATH
- Using this I won't have to bother about the exact location where these modules are present and load in each macro with respect to the relative path
- Earlier, if I change the name of main directory from "Fiducial_XS" to somethine else then few macros won't able to load.

* Don't remove the executable main_fiducialXSTemplates everytime; it will be updated if we updated the main_fiducialXSTemplates.cpp using make command

* Now, plot2dsigeffs.py is importing label name from YAML file

* Added unit in the observabel YAML file, its used in the plotDifferentialBins.py; Now, removed many unit related line from plotDifferentialBins.py, as its taken from YAML file now

* - moved back the ROOT import where it was earlier because of optparser and ROOT options interface.
- Reference: https://root-forum.cern.ch/t/python-options-and-root-options/4641/3

* removed __main__ from efficiencyFactors.py

* Added GEN into in observables_list.yml file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants