-
Couldn't load subscription status.
- Fork 222
DOC-1928: Clean up partials/configuration directory
#3592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: tinymce/7
Are you sure you want to change the base?
Conversation
| .**Default value:** | ||
| [source,js] | ||
| ---- | ||
| exportword_converter_options: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please explain why you removed the exportword_converter_options part in the example. I feel like in the current format was easier to understand with the exportword_converter_options remaining. If the vision is to just say what the default value is maybe not having it a code snippet is easier possibly a sentence.
| .**Default value:** | ||
| [source,js] | ||
| ---- | ||
| importword_converter_options: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar question to the export_word. I'm just worried that it's a bit confusing to understand with no prior experience to remove that the function in the default value. I see that it's in the example so it's not hard for someone to put it together. If I could get an explanation to the idea of removing the function name, I'd really appreciate it :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall very good! Just got a question about removing the function names from the default values section
|
Ticket: DOC-1928
Site: Staging branch
I recreated the original PR and retained only the essential changes that are fixing something with factual inaccuracy or visual bug. This PR is oly 46 files with small changes in each, so it is easier to review. All changes in this PR have been visually checked for correction using a side-by-side comparison between
tinymce/7andhotfix/7/DOC-1928_3.Changes:
sidebar_showcode exampletypography_langstype from Object to ArrayServiantoSerbianfalsetype toanchor_bottomandanchor_toptruetype toauto_focusauto_focus: trueautoresize_bottom_marginautoresize_overflow_paddingfullfortinycomments_accesscontent_csscustom_elementscustom_ui_selectordirectionalitydoctypeimportword_converter_optionsfrom String to Objectindentationabout the default valuefalsetype for insert_toolbar`mentions_selectorfrom Function to String and add default valuenonbreaking_force_tabnoneditable_regexpfrom String to RegExpobject_resizingpagebreak_separatorpowerpaste_allow_local_imagespowerpaste_html_importresizefalsetype for selection_toolbar`table_gridtableofcontents_headertext_color.adoctoolbar_modevideo_templete_callbackfrom String to FunctionPre-checks:
feature/<version>/,hotfix/<version>/,staging/<version>/, orrelease/<version>/.modules/ROOT/nav.adochas been updated(if applicable).release noteentry for anyNew product features.productminorversioninantora.ymland added new supported versions entry inmodules/ROOT/partials/misc/supported-versions.adoc.Review: