fix(embeddings): scope the memory client's default embedder to config credentials - #5515
1 finding
The original four-file fix (add default_embedding_provider_with_config and route the two config-holding callers through it) matches the PR description accurately. However, the commit added since the last review modifies src/openhuman/inference/embeddings/rpc.rs — a fifth file — to adjust a test for a tinymemory v1.0.1 effective-embedder ladder change. This is not mentioned in the body, and the body explicitly claims the diff "touches only four src/openhuman/** files," which is now false. The new test comment also references #5402, an issue the description never raises. The description needs to be updated to disclose this test-side change and its tinymemory routing rationale. The code index for this repository is cold, so this review saw the diff alone.
| Finding | Where | |
|---|---|---|
 |
Description claims four files touched; this commit touches a fifth (rpc.rs test) | (pull request description) |
 Description claims four files touched; this commit touches a fifth (rpc.rs test)
(pull request description)
[RULE] PR description accuracy
The PR body asserts "this diff touches only four src/openhuman/** files", but the added commit modifies a fifth file — src/openhuman/inference/embeddings/rpc.rs — adjusting a test to accommodate a tinymemory v1.0.1 effective-embedder ladder change. That test modification is not mentioned anywhere in the description, and the body's CI-note section frames all non-#5501 failures as pre-existing breakage inherited from main, which this commit is not. The description should disclose this test-side change and the tinymemory routing rationale.
