fix(hooks): replace embedder callbacks by name - #5450
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 36 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 475c9be447
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let mut hooks = EMBEDDER_POST_TURN_HOOKS | ||
| .lock() | ||
| .expect("embedder post-turn hooks poisoned"); | ||
| hooks.retain(|registered| registered.name() != name); |
There was a problem hiding this comment.
When the registry owns the last Arc, this retain both calls embedder-controlled name() and drops the removed callback while EMBEDDER_POST_TURN_HOOKS is locked. During a core rebuild, a callback whose Drop or name() re-enters registration/replacement—or acquires a host lock in the inverse order—will deadlock this registry and block every subsequent registration or snapshot. Move embedder-controlled calls and destruction outside the mutex; replace_embedder_tool_hook has the same issue.
Useful? React with 👍 / 👎.
1 participant
Embedder lifecycle registrations are process-global. Add replacement APIs so hosts that retry or rebuild their core do not retain stale callbacks.