fix(mcp): read a scoped overlay teammate's own grant, and bound add_agent by its minter - #745
Merged
Merged
TinySweeper / tinysweeper/critique
succeeded
Aug 12, 2026 in 0s
Reviewed 5 files; 2 findings. _Code retrieval was unavailable (model: openrouter
Reviewed 5 files; 2 findings. Code retrieval was unavailable (model: openrouter embeddings returned 404 Not Found: {"error":{"message":"No allowed providers are available for the selected model. Providers serving openai/text-embedding-3-small: openai, azure, but your account's allowed-providers setting permits only: deepinfra, streamlake, digitalocean. To change your allowed providers, visit: https://openrouter.ai/settings/privacy","code":404,"metadata":{"available_providers":["openai","azure"],"requested_prov), so this review saw the diff alone.
No findings.
Fixed since the last review
- The admin check runs before the agent exists — no admin check or equivalent ordering concern is visible anywhere in the shown diff for
src/harness/orchestrator.rs; the prior finding is not present in the current code and is dropped. - The admin check runs before the agent exists
- The admin check runs before the agent exists — addressed; the comment at the top of
edit_agentnow explicitly documents the ordering and its rationale ("Authority before the write lock: a refused edit must not hold the lock, and must not have looked at the record either"). Returning 403 before probing record existence is standard authorization-before-existence practice and prevents a refused edit from acquiring the write lock or loading the record. No longer a concern.
Loading