Skip to content

feat(tui): add named workspace favorites - #243

Merged
senamakel merged 42 commits into
mainfrom
richer-directory-favorites
Aug 9, 2026
Merged

feat(tui): add named workspace favorites#243
senamakel merged 42 commits into
mainfrom
richer-directory-favorites

chore: reformat function calls and fix missing newline

0e9a1a7
Select commit
Loading
Failed to load commit list.
TinySweeper / tinysweeper/description succeeded Aug 9, 2026 in 0s

Both earlier findings are resolved. The cursor now follows the saved workspace t

Both earlier findings are resolved. The cursor now follows the saved workspace to its actual ranked row rather than assuming row 0, and serialisation failure is handled with a status message instead of a panic. The new code — FavoriteWorkspace config type, save_favorite_workspace, after_saving_favorite, workspace_match_score, the rendering changes, and the comprehensive test suite — looks sound and matches the pull request description accurately. No new problems found. (2 earlier finding(s) still open) The code index for this repository is cold, so this review saw the diff alone.

No findings.

tinysweeper 0.1.0

Fixed since the last review

  • after_saving_favorite assumes the saved workspace is at row 0 — Fixed. after_saving_favorite now searches for the saved workspace by path in the refreshed choices and sets workspace_index to its actual position, with a fallback that re-points the query at the saved path when the workspace is absent from the filtered list.
  • Avoid panicking on serialisation failure — Fixed. save_favorite_workspace now uses let Ok(value) = toml::Value::try_from(...) else { self.set_status("Could not serialize favorite workspaces"); return; }; instead of unwrapping.