-
Notifications
You must be signed in to change notification settings - Fork 6
feat(tui): animate the harness status line and capture every attention state #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 72 commits
Commits
Show all changes
84 commits
Select commit
Hold shift + click to select a range
f7e1891
feat(tui): animate harness states and add error detection
senamakel 4e37344
test: add new fields to test fixtures
senamakel 821d5e8
fix(tui): remove unused ATTENTION_GLYPH import
senamakel 93320bd
fix(event_loop): use public path for frame interval constant
senamakel 9397b4b
chore(settings): clarify appearance usage text
senamakel e348174
fix(settings): show blink duration in appearance usage
senamakel fd0541d
refactor(tui): simplify appearance state handling
senamakel d83f15f
refactor(tui): simplify appearance state handling
senamakel 8e73032
refactor(tui): simplify appearance state handling
senamakel 494b1de
chore(tui): import blink timing helpers
senamakel c467ea3
fix(attention): handle session close during attention wait
senamakel 1881680
test(rail): add attention tests
senamakel d1a2f4c
fix(rail): show agent status when rail is selected
senamakel 518dd6a
fix(test): correct idle harness spinner assertion
senamakel 1017882
fix(attention): handle pty resize events in detect loop
senamakel 68d2710
test(tui): update settings navigation for extra attention control
senamakel e7e0d88
test(feature_settings): add tests for feature settings
senamakel f8e86a8
test(theme): cover blink rate parsing and pulsing edge cases
senamakel fa0d22a
test(attention): cover blocking error detection and cue precedence
senamakel d1e8b10
test(session): add tests for attention session handling
senamakel a4f2961
test: add session_tests module to attention test suite
senamakel 09e1179
style: format long expressions for readability
senamakel f7bf3f2
refactor(theme): use is_multiple_of for blink phase check
senamakel 710789f
fix(pty): handle attention requests without active sessions
senamakel 480944d
fix(pty): handle attention types without panicking
senamakel 283033a
fix(pty): handle attention requests without a session
senamakel 949d703
fix(pty): handle attention detection edge case
senamakel f282870
fix(attention): handle pty resize events in detect loop
senamakel b41f823
test(attention): cover Claude live progress lines in working detection
senamakel ad461cb
docs(config): document attention and attentionBlink options
senamakel c6272c6
docs(config): document status line run-state glyphs
senamakel 4f18c0e
fix(pty): handle attention requests without a pty
senamakel 1d5a5f9
docs(developers): document the TUI in the developer guide
senamakel 451081b
docs(configuration): document theme attention color options
senamakel 767d2cf
chore(tui): reformat attention matcher lines
senamakel 8e31c74
fix(attention): remove stray comment marker in Claude permission markers
senamakel 66a95fd
Merge remote-tracking branch 'refs/remotes/upstream/main' into pr/235
senamakel 9184552
fix(worker): render activity and attention pulses
senamakel 905faf8
fix(worker): honor lifecycle attention cues
senamakel fc904da
fix(ui): preserve attention state
senamakel aac994d
fix(worker): distinguish idle composer state
senamakel 4356c5d
fix(tui): refine harness attention rendering
senamakel 72d7940
chore(tui): rename state module to app_state
senamakel 176f80f
test(tui): use setter for attention blink rate in feature settings test
senamakel 6ba777b
Merge remote-tracking branch 'refs/remotes/upstream/main' into pr/235
senamakel b95d120
fix(tui): harden attention cues
senamakel 8779fdf
Merge remote-tracking branch 'refs/remotes/upstream/main' into pr/235
senamakel 34de2be
chore: files changed src/tui/src/worker/pty/attention/tests.rs
senamakel 17b4475
fix(tui): validate attention cues
senamakel db9b70b
chore: files changed src/tui/src/worker/pty/attention/detect.rs
senamakel 90d9190
chore: files changed src/tui/src/worker/pty/attention/lifecycle_tests.rs
senamakel 114c654
chore: files changed src/tui/src/worker/pty/attention/detect.rs,src/t…
senamakel 2affb90
fix(tui): keep attention cues accurate after wrapped errors and answe…
senamakel ada24b9
fix(tui): keep wrapped error continuations from reading as recovery
senamakel bd391bf
fix(tui): validate the matched error line itself as terminal
senamakel cb8e7cc
fix(tui): do not treat a requested close as a lifecycle failure
senamakel 94e79f2
fix(tui): stamp a write failure with the moment it happened
senamakel 6eab483
fix(tui): suppress close-induced writer errors as failures
senamakel d8ca2d8
fix(tui): draw a dispatched task row's failed harness in red
senamakel 75c5822
test(tui): move task-row tests to the rows sibling module
senamakel 9aeb37f
chore: files changed src/tui/src/worker/pty/attention/detect.rs
senamakel e88b4f1
chore: files changed src/tui/src/worker/pty/attention/detect.rs
senamakel fe500a0
chore: files changed src/tui/src/worker/pty/attention/tests.rs
senamakel 15c9f1e
chore: files changed gitbooks/developers/the-tui.md
senamakel 3cf38d8
chore: files changed src/tui/src/worker/pty/attention/detect.rs
senamakel 68f2946
chore: files changed src/tui/src/worker/pty/attention/tests.rs
senamakel f032629
chore: files changed src/tui/src/worker/pty/attention/detect.rs
senamakel 125986b
chore: files changed src/tui/src/worker/pty/attention/tests.rs
senamakel 674d799
chore: files changed src/tui/src/worker/pty/attention/detect.rs
senamakel ac89d39
chore: files changed src/tui/src/worker/pty/attention/tests.rs
senamakel 799c752
chore: files changed src/tui/src/worker/pty/attention/tests.rs
senamakel 64c025c
chore: files changed src/tui/src/worker/pty/attention/tests.rs
senamakel 089a0bd
chore: files changed src/tui/src/worker/pty/attention/detect.rs
senamakel 735f041
chore: files changed src/tui/src/worker/pty/attention/tests.rs
senamakel 6890342
chore: files changed src/tui/src/worker/pty/attention/tests.rs
senamakel 2ca2358
chore: files changed src/tui/src/worker/pty/attention/tests.rs
senamakel 0d1c7cc
chore: files changed src/tui/src/worker/pty/attention/detect.rs
senamakel 608cfbe
chore: files changed src/tui/src/worker/pty/attention/detect.rs
senamakel 770696b
chore: files changed src/tui/src/worker/pty/attention/tests.rs
senamakel 684a2c0
Merge remote-tracking branch 'refs/remotes/upstream/main' into pr/235
senamakel 3b6beff
chore: files changed src/sdk/src/codex_overrides/tests.rs
senamakel e630a04
merge: resolve codex_overrides conflict with unescape_toml_string helper
senamakel d28c378
refactor(tests): split monolithic attention test file into per-catego…
senamakel 8fe35f5
fix(tests): correct indentation of pairs.insert call
senamakel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.