os,runtime: make sure executable path is fully resolved at process init #4881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure I like this solution; it pulls in a bunch of code from syscall to get the cwd at process init. |
aykevl
reviewed
Oct 4, 2025
|
|
||
| var executablePath string | ||
|
|
||
| func platform_argv(argc int32, argv *unsafe.Pointer) { |
There was a problem hiding this comment.
Hmm, I'm not sure I like this name. What about storeExecutablePath or something like that?
Comment on lines
+295
to
+296
| const pathMax = 1024 | ||
| var buf [4 * pathMax]byte |
There was a problem hiding this comment.
Why use 1024 and then use 4 times that size in the actual buffer? (Also, it would help to give a pointer to why that is the right value, like a link to a man page or something).
| if n < 1 { | ||
| return "" | ||
| } | ||
| return string(buf[:n]) |
There was a problem hiding this comment.
You could consider using unsafe.String here to avoid an allocation. It should be safe, since buf is never modified afterwards. (The potential downside is that executablePath will then always be 4kB in size - not sure whether that's a good tradeoff).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.