Fix unread message counter not accounting for deleted messages #970
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When a user deletes messages from a conversation, the unread message counters for other users are not updated to reflect that some of their unread messages have been deleted. This causes incorrect unread counts to be displayed in the UI.
Scenario:
This affects both online users and users who come back online later.
Root Cause
The
handleNoteBroadcast
function calculates unread counts using simple arithmetic (pud.readID - msg.Note.SeqId
) without considering that some messages in the range may have been deleted. ThereplyDelMsg
function successfully deletes messages but doesn't update unread counters for affected users.Solution
Added logic to update unread counters when messages are soft-deleted:
Helper function
calculateUnreadInRanges
: Efficiently calculates how many unread messages fall within given deletion ranges using intersection logic.Enhanced
replyDelMsg
: After successful soft deletion, iterates through all users with read permissions and decreases their unread count by the number of unread messages that were deleted.Minimal performance impact: Only runs during message deletion operations (rare events), not during normal read operations.
Technical Details
usersUpdateUnread
infrastructure for consistencyTesting
calculateUnreadInRanges
covering edge casesExample calculation:
Fixes #898
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.