Skip to content
This repository was archived by the owner on Oct 5, 2022. It is now read-only.

Run 'lint-install', address lint issues raised #11

Merged
merged 2 commits into from
Sep 11, 2021

Conversation

tstromberg
Copy link
Contributor

See tinkerbell/lint-install#9

This adds new makefile rules: lint and fix, and addresses the following lint issues raised:

test/_kind/kind_test.go:124: File is not `gofumpt`-ed (gofumpt)

test/_kind/kind_test.go:125: File is not `gofmt`-ed with `-s` (gofmt)

test/_kind/kind_test.go:155:24: response body must be closed (bodyclose)
		resp, err := http.Get("http://localhost:42114/healthz")
		                     ^
test/_kind/kind_test.go:251:23: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
func registerHardware(ctx context.Context) error {
                      ^
test/_vagrant/vagrant_test.go:59:24: response body must be closed (bodyclose)
		resp, err := http.Get("http://localhost:42114/healthz")
		                     ^
test/_vagrant/vagrant_test.go:165:23: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
func registerHardware(ctx context.Context) error {
                      ^

Signed-off-by: Thomas Stromberg <t+github@stromberg.org>
Signed-off-by: Thomas Stromberg <t+github@stromberg.org>
@tstromberg tstromberg merged commit e54caf9 into tinkerbell:main Sep 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants