Skip to content

Fix parse_duration to handle days (d) unit #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
desh16gmz wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix parse_duration to handle days (d) unit #63

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07d7eed
Fix parse_duration to handle days (d) unit
desh16gmz Jun 14, 2026
984f35f
Fix: add 'd' (days) unit to _UNITS mapping (86400s)
desh16gmz Jun 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions duration_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
# Seconds per unit. Supported: weeks, hours, minutes, seconds.
_UNITS = {
"w": 604800,
"d": 86400,
"h": 3600,
"m": 60,
"s": 1,
Expand All @@ -21,6 +22,7 @@ def parse_duration(text: str) -> int:
Examples:
parse_duration("1h30m") -> 5400
parse_duration("1w") -> 604800
parse_duration("2d4h") -> 187200

Raises ValueError on empty or malformed input.
"""
Expand Down