fix: count days in duration parser#53
Open
KaisAbiyyi wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds support for parsing days (d) in duration strings across implementation, tests, and documentation.
Changes:
- Add
d(days) to supported duration units induration_utils.py - Expand unit parsing tests to cover days and multi-unit combinations
- Update README usage examples to include day-based durations
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/test_duration_utils.py | Adds coverage for parsing d and mixed unit strings including w+d+h+m+s. |
| duration_utils.py | Extends _UNITS with days and documents an additional example. |
| README.md | Documents d usage through an added example call. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1
Summary:
dunit to the duration unit table so day values are counted as 86400 seconds.1d,2d4h, and an all-unit combined duration string.dsupport has a visible working example.Comparison with existing submissions:
Demo:
Verification:
python -m unittest discover -s tests1d -> 86400,2d4h -> 187200,1w2d3h4m5s -> 788645git diff --checkBounty context: resolves the $50 Algora bounty on #1.