Allow for higher amounts raised than goal amount . #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't break the progress bar if raised amount is higher than goal amount.
|
Thanks for the contribution. While this is a good idea I think it makes sense as a configuration option as technically the visualization would not be accurate. If you could amend your PR to have this be optional rather than enforced, that would be great. Thanks. |
|
The 'fill' goes outside the container if you reach a target higher than your goal set. So if it's 200 / 100, the fill bar is double the size of the container |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't break the progress bar if raised amount is higher than goal amount.