Refresh plugin #234
Open
Refresh plugin #234
+107
−104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
reviewed
Dec 18, 2024
Comment on lines
+61
to
+65
| <dependency> | ||
| <groupId>org.gitlab</groupId> | ||
| <artifactId>java-gitlab-api</artifactId> | ||
| <version>4.0.0</version> | ||
| </dependency> |
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks @basil . This change
<dependency>
<groupId>io.jenkins.plugins</groupId>
<artifactId>gitlab-api</artifactId>
</dependency>
causes a bunch of issues. for example:
] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /Users/shlomodahan/Desktop/jenkins_plugins/jenkins-gitlab-merge-request-builder-plugin/src/main/java/org/jenkinsci/plugins/gitlab/Gitlab.java:[5,22] package org.gitlab.api does not exist
[ERROR] /Users/shlomodahan/Desktop/jenkins_plugins/jenkins-gitlab-merge-request-builder-plugin/src/main/java/org/jenkinsci/plugins/gitlab/Gitlab.java:[6,29] package org.gitlab.api.models does not exist
[ERROR] /Users/shlomodahan/Desktop/jenkins_plugins/jenkins-gitlab-merge-request-builder-plugin/src/main/java/org/jenkinsci/plugins/gitlab/Gitlab.java:[7,29] package org.gitlab.api.models does not exist
[ERROR] /Users/shlomodahan/Desktop/jenkins_plugins/jenkins-gitlab-merge-request-builder-plugin/src/main/java/org/jenkinsci/plugins/gitlab/Gitlab.java:[14,13] cannot find symbol
symbol: class GitlabAPI
location: class org.jenkinsci.plugins.gitlab.Gitlab
[ERROR] /Users/shlomodahan/Desktop/jenkins_plugins/jenkins-gitlab-merge-request-builder-plugin/src/main/java/org/jenkinsci/plugins/gitlab/Gitlab.java:[25,12] cannot find symbol
symbol: class GitlabAPI
likely related to how we are importing the package.
import org.gitlab.api.GitlabAPI;
import org.gitlab.api.models.GitlabCommitStatus;
import org.gitlab.api.models.GitlabProject;
What is the correct approach for handling this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.