Skip to content
This repository was archived by the owner on Aug 16, 2022. It is now read-only.

Update to modernize gems and deps - #15

Open
samnissen wants to merge 10 commits into
timkoopmans:masterfrom
samnissen:update-to-modernize-gems-and-deps
Open

Update to modernize gems and deps#15
samnissen wants to merge 10 commits into
timkoopmans:masterfrom
samnissen:update-to-modernize-gems-and-deps

Conversation

@samnissen

Copy link
Copy Markdown

Fixes #14

But it got a bit messy, mostly due to my lack of experience crafting gems. Specifically I'll call out:

  • jeweler – I don't know it, and so perhaps I'm doing something wrong there.
  • I bumped version number, not sure if that's SOP or not.
  • I commented out rspec before and after context blocks that aren't being used, but obviously that's a style decision you might want to reverse.
  • I originally changed authorship details as I thought that might be SOP, but looking at GitHub's contributors graph I can see that's abnormal.

@samnissen

Copy link
Copy Markdown
Author

@90kts Hello. Can this be reviewed? Thanks!

@MacCracken

Copy link
Copy Markdown

if you are still waiting for this I've released watir-performance that is updated version of this repo.

@timkoopmans

Copy link
Copy Markdown
Owner

Hey sorry I can't maintain this anymore. @MacCracken @samnissen would either of you two like to take ownership/transfer of this repository?

@samnissen

Copy link
Copy Markdown
Author

@90kts I can take that on. Let me know if you need anything from me to make it happen

@MacCracken

MacCracken commented May 8, 2018 via email

Copy link
Copy Markdown

@samnissen

Copy link
Copy Markdown
Author

@90kts @MacCracken I'm not opposed to that plan, though I believe any successor to this gem should maintain the connection to this repo through a GitHub fork. I'm glad to help pitch in on whatever.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants