Adding repace_table() #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-entrup
reviewed
Oct 13, 2019
| pass | ||
|
|
||
| def replace_table(self, label: str, data) -> None: | ||
| def replace_table(self, label: str, data, header=False, rownames=False): |
There was a problem hiding this comment.
We allow use kwargs only for header and rownames:
def replace_table(self, label: str, data, *, header=False, rownames=False):In my opinion it's better to use None instead of False. When using False as default value I assume a Boolean value is required. None is no valid data fore these arguments and therefore it should be fine to use it. Using an Undefined() object could be an option, too. But I think this is not necessary in this case.
lysnikolaou
reviewed
Oct 13, 2019
| pass | ||
| assert isinstance(data, pandas.dataframe) | ||
|
|
||
| shapes_to_replace = self._find_shapes(label) |
There was a problem hiding this comment.
In #7, the method signature of _find_shapes was changed? Maybe change this to reflect that?
lysnikolaou
requested changes
Oct 13, 2019
| data (pandas.DataFrame): table to be inserted into the presentation | ||
| """ | ||
| pass | ||
| assert isinstance(data, pandas.dataframe) |
There was a problem hiding this comment.
You could remove the assertion here and include type hints in the method signature like so:
def replace_table(self, label: str, data: pandas.dataframe, *, header: bool = False, rownames: bool = False) -> None:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Adding my replace_table() from yesterday. Tests not yet created.
Best,
Martin