Skip to content

Conversation

hymccord
Copy link

No description provided.

@Copilot Copilot AI review requested due to automatic review settings August 20, 2025 20:50
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors URL parsing to support SSH remotes by replacing hardcoded GitHub URL parsing with a dedicated GitUri class. The changes enable the extension to handle both HTTPS and SSH Git remote URLs.

  • Replaced hardcoded URL string parsing with a robust GitUri parser
  • Changed FindGitFolder to TryFindGitFolder with proper boolean return semantics
  • Added comprehensive SSH and HTTPS URL parsing support

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
src/ToolWindows/GHActionsToolWindow.xaml.cs Updated to use new TryFindGitFolder method with boolean return
src/Helpers/RepoInfo.cs Refactored git folder discovery and URL parsing to use GitUri class
src/Helpers/GitUri.cs New class providing comprehensive Git URL parsing for SSH and HTTPS remotes
src/GitHubActionsVS.csproj Added GitUri.cs to project compilation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@hymccord
Copy link
Author

hymccord commented Aug 20, 2025

This may help with #26 as it was the same symptoms happening to me, though my stack traces indicated errors with SSH.

It also may help move towards supporting GitHub Enterprise but I have no way of testing that. There are a few other areas to touch like the credentials. Out of scope for the PR though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants