feat: add --transfer-accounts flag for 2UP shared account deduplication#61
Open
alecpirillo wants to merge 1 commit intotim-smart:mainfrom
Open
feat: add --transfer-accounts flag for 2UP shared account deduplication#61alecpirillo wants to merge 1 commit intotim-smart:mainfrom
alecpirillo wants to merge 1 commit intotim-smart:mainfrom
Conversation
Adds a --transfer-accounts option that accepts account mappings used only for transfer payee resolution without syncing those accounts. Resolves duplicate transactions when two Up Bank users share a joint (2UP) account and run separate sync jobs. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Contributor
Author
|
Consider that is a very specific use case and may not be appropriate to bundle into an agnostic sync tool. Thinking about it this morning, this feature could be expanded to be more universal. It could be used to link transactions to other accounts in actual, not just up specific transfers which is my use case. This is capability that can be achieved in actual with rules (and merging any dups manually), but it does greatly simplify on boarding for new users who decide to use the feature and makes sync smarter as a whole. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a --transfer-accounts option that accepts account mappings used only for transfer payee resolution without syncing those accounts. Very useful feature for when you are running this sync multiple times across multiple up users with UP connector. For example syncing both partners individual up accounts, with the new flag you can specify which accounts are represented in other sync runs, allowing automatic identification as transfers. Means no manual de-duplication in actual. 2 new tests - 1 to validate the prior feature for joint de-duplication, and one for this use case.
Not sure if its useful enough to earn its own section in the read me - feel free to remove.