Use created at date instead of settled for transaction date#59
Merged
tim-smart merged 2 commits intotim-smart:mainfrom Mar 16, 2026
Merged
Use created at date instead of settled for transaction date#59tim-smart merged 2 commits intotim-smart:mainfrom
tim-smart merged 2 commits intotim-smart:mainfrom
Conversation
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Up Bank transactions are now imported using
createdAt(when the purchase was made) rather thansettledAt(when it cleared). This maybe based on personal preference, but the Up app maintains 'createdAt' as the transaction date in the UI, so this PR makes transaction match the date shown in the Up app. This is valuable for reconciliation as actual will match record ordering of the Up app UI. This could be worth making configurable in the future.